From c9bbef63805462d0d251d4453d2bf2bb0d7377c7 Mon Sep 17 00:00:00 2001
From: etagle <ejtagle@hotmail.com>
Date: Wed, 11 Oct 2017 03:28:52 -0300
Subject: [PATCH] Cosmetic fix for HAL_AVR/MarlinSerial.cpp
Instead of using const char, it is better to use uint8_t
---
Marlin/src/HAL/HAL_AVR/MarlinSerial.cpp | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Marlin/src/HAL/HAL_AVR/MarlinSerial.cpp b/Marlin/src/HAL/HAL_AVR/MarlinSerial.cpp
index 88258e119e..025254481e 100644
--- a/Marlin/src/HAL/HAL_AVR/MarlinSerial.cpp
+++ b/Marlin/src/HAL/HAL_AVR/MarlinSerial.cpp
@@ -84,7 +84,7 @@
// Currently looking for: M108, M112, M410
// If you alter the parser please don't forget to update the capabilities in Conditionals_post.h
- FORCE_INLINE void emergency_parser(const unsigned char c) {
+ FORCE_INLINE void emergency_parser(const uint8_t c) {
static e_parser_state state = state_RESET;
@@ -169,13 +169,16 @@
#endif // EMERGENCY_PARSER
FORCE_INLINE void store_rxd_char() {
+
const ring_buffer_pos_t h = rx_buffer.head,
i = (ring_buffer_pos_t)(h + 1) & (ring_buffer_pos_t)(RX_BUFFER_SIZE - 1);
+ // Read the character
+ const uint8_t c = M_UDRx;
+
// If the character is to be stored at the index just before the tail
// (such that the head would advance to the current tail), the buffer is
// critical, so don't write the character or advance the head.
- const char c = M_UDRx;
if (i != rx_buffer.tail) {
rx_buffer.buffer[h] = c;
rx_buffer.head = i;
@@ -194,6 +197,7 @@
#endif
#if ENABLED(SERIAL_XON_XOFF)
+
// for high speed transfers, we can use XON/XOFF protocol to do
// software handshake and avoid overruns.
if ((xon_xoff_state & XON_XOFF_CHAR_MASK) == XON_CHAR) {