From fb6b62a01bff9f55dfa7f7aedf1f23e6e88fe5ad Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Sun, 24 Dec 2017 22:53:05 -0600 Subject: [PATCH] Comment `return false` in motion functions --- Marlin/Marlin_main.cpp | 10 ++++------ Marlin/ubl_motion.cpp | 2 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Marlin/Marlin_main.cpp b/Marlin/Marlin_main.cpp index 3679a2b2d9..75bcb49201 100644 --- a/Marlin/Marlin_main.cpp +++ b/Marlin/Marlin_main.cpp @@ -13027,7 +13027,6 @@ void set_current_from_steppers_for_axis(const AxisEnum axis) { } else { // Must already have been split on these border(s) - // This should be a rare case. buffer_line_to_destination(fr_mm_s); set_current_from_destination(); return; @@ -13096,7 +13095,6 @@ void set_current_from_steppers_for_axis(const AxisEnum axis) { } else { // Must already have been split on these border(s) - // This should be a rare case. buffer_line_to_destination(fr_mm_s); set_current_from_destination(); return; @@ -13139,7 +13137,7 @@ void set_current_from_steppers_for_axis(const AxisEnum axis) { // If the move is only in Z/E don't split up the move if (!xdiff && !ydiff) { planner.buffer_line_kinematic(rtarget, _feedrate_mm_s, active_extruder); - return false; + return false; // caller will update current_position } // Fail if attempting move outside printable radius @@ -13236,7 +13234,7 @@ void set_current_from_steppers_for_axis(const AxisEnum axis) { planner.buffer_line_kinematic(rtarget, _feedrate_mm_s, active_extruder); #endif - return false; + return false; // caller will update current_position } #else // !IS_KINEMATIC @@ -13257,7 +13255,7 @@ void set_current_from_steppers_for_axis(const AxisEnum axis) { return true; // all moves, including Z-only moves. #elif ENABLED(SEGMENT_LEVELED_MOVES) segmented_line_to_destination(MMS_SCALED(feedrate_mm_s)); - return false; + return false; // caller will update current_position #else /** * For MBL and ABL-BILINEAR only segment moves when X or Y are involved. @@ -13276,7 +13274,7 @@ void set_current_from_steppers_for_axis(const AxisEnum axis) { #endif // HAS_MESH buffer_line_to_destination(MMS_SCALED(feedrate_mm_s)); - return false; + return false; // caller will update current_position } #endif // !IS_KINEMATIC diff --git a/Marlin/ubl_motion.cpp b/Marlin/ubl_motion.cpp index 33570af345..5a8cf8c022 100644 --- a/Marlin/ubl_motion.cpp +++ b/Marlin/ubl_motion.cpp @@ -616,6 +616,8 @@ } // segment loop } // cell loop + + return false; // caller will update current_position } #endif // UBL_SEGMENTED