From 7a6cbf75b9f43d582c24f61a1a058cefdf239992 Mon Sep 17 00:00:00 2001 From: Marek Bel Date: Mon, 6 Aug 2018 18:10:40 +0200 Subject: [PATCH] Fix compiler warnings: sketch/cardreader.cpp: In member function 'void CardReader::openFile(const char*, bool, bool)': sketch/cardreader.cpp:350:25: warning: ordered comparison of pointer with integer zero [-Wextra] sketch/cardreader.cpp:355:22: warning: ordered comparison of pointer with integer zero [-Wextra] --- Firmware/cardreader.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Firmware/cardreader.cpp b/Firmware/cardreader.cpp index fe181362..6f61d23b 100644 --- a/Firmware/cardreader.cpp +++ b/Firmware/cardreader.cpp @@ -343,16 +343,16 @@ void CardReader::openFile(const char* name,bool read, bool replace_current/*=tru curDir=&root; const char *fname=name; - char *dirname_start,*dirname_end; + const char *dirname_start,*dirname_end; if(name[0]=='/') { - dirname_start=strchr(name,'/')+1; - while(dirname_start>0) + dirname_start = name + 1; + while(*dirname_start) { dirname_end=strchr(dirname_start,'/'); //SERIAL_ECHO("start:");SERIAL_ECHOLN((int)(dirname_start-name)); //SERIAL_ECHO("end :");SERIAL_ECHOLN((int)(dirname_end-name)); - if(dirname_end>0 && dirname_end>dirname_start) + if(dirname_end && dirname_end>dirname_start) { char subdirname[13]; strncpy(subdirname, dirname_start, dirname_end-dirname_start);