3DPrinting/Prusa-Firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug: M20 - List SD card

Browse Source 
When the SD card is inserted in a Mac computer some special directory are written. The purse firmware is unable to navigate those directory and generates an error sent showed on the serial line.

the BUG is the instruction SERIAL_ECHOLN does not work with string pointers and there fore garbage is sent on the serial line.

The proposed correction is to use the right instruction: SERIAL_ECHORPGM that works with string pointers.
Therefore the correct message is MSG_SD_CANT_ENTER_SUBDIR and not the original listed.
This commit is contained in:
Alfredo 2017-03-07 09:37:15 -05:00 committed by GitHub
parent de15b572cf
commit 7b86fa6016
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Firmware/cardreader.cpp
View File

@ -81,7 +81,7 @@ void CardReader::lsDive(const char *prepend, SdFile parent, const char * const m
if(lsAction==LS_SerialPrint) if(lsAction==LS_SerialPrint)
{ {
SERIAL_ECHO_START; SERIAL_ECHO_START;
SERIAL_ECHOLN(MSG_SD_CANT_OPEN_SUBDIR); SERIAL_ECHORPGM(MSG_SD_CANT_ENTER_SUBDIR);
SERIAL_ECHOLN(lfilename); SERIAL_ECHOLN(lfilename);
} }
} }