DRracer
1a7a313cbf
Merge pull request #3311 from wavexx/temp_runaway_fixes
...
Ensure THERMAL RUNAWAY / temperature errors stay on-screen
2021-12-14 06:53:27 +01:00
Yuri D'Elia
3849f9785a
Make cancel_heatup also abort cooldown in M190
...
This matches the expected behavior, as already implemented in
wait_for_heater().
2021-12-10 01:51:43 +01:00
Yuri D'Elia
320835a1b7
Do not cancel wait-for-temperature loops in disable_heaters()
...
Partially revert previous change: cancelling a single loop would often
advance the gcode stream to the next wait-for loop if executed at the
beginning of an SD print, implicitly turning off the flag again.
Cancel the loop directly in UnconditionalStop() which stops the command
queue as well in an atomic way, handling this correctly.
2021-12-10 01:46:20 +01:00
Yuri D'Elia
32d8d892f5
Actually call UnconditionalStop() in Stop()->lcd_print_stop()
...
Remove incorrect check introduced during development.
2021-12-10 01:43:59 +01:00
Yuri D'Elia
83693bf4cc
Remove useless assignment in lcd_cooldown
...
The current filament action will be aborted by lcd_return_to_status()
2021-12-07 19:27:18 +01:00
Yuri D'Elia
78f856c8d6
Do not unconditionally overwrite the status message in check_file()
...
No function should touch the status message directly without checking
the message severity level first. Replace the strcpy_P with
lcd_setstatuspgm().
2021-12-07 19:27:18 +01:00
Yuri D'Elia
7ff117d0c4
temp_runaway_stop: remove spourious space in error message
2021-12-07 19:27:18 +01:00
Yuri D'Elia
36a7b5ca56
Avoid redundant checks in lcd_setalertstatus*
2021-12-07 19:27:18 +01:00
Yuri D'Elia
a3915b57b9
Improve temp_runaway_stop robustness
...
Remove most of the duplicated code inside temp_runaway_stop(),
making it identical to the other temperature handlers.
Move the lower-level functions required to stop the entirety of the
machine into UnconditionalStop(). Reuse this function inside
lcd_print_stop().
Set the LCD alert message before calling Stop(), as done in other safety
handlers, so that the error is visible while the printer is stopping.
This also avoids other temporary status messages to appear before
the real issue is shown and/or STEALING the first CRITICAL alert
level before we do.
2021-12-07 19:25:34 +01:00
Yuri D'Elia
57abffda1b
Update temperature-related error message to use LCD_STATUS_CRITICAL
2021-12-07 11:09:58 +01:00
Yuri D'Elia
fb025bba05
Introduce severity levels for alert messages
...
Use the internal lcd_status_message_level for multiple severity levels
of alert messages.
This is needed to distinguish between non-critical alerts (such as FAN
ERROR) from critical ones (any heater issue). During a failure
scenario, a critical error MUST NOT be overridden by a lower-level one.
As such LCD_STATUS_CRITICAL is currently used for all heater-related
errors that result in a safety full-stop.
2021-12-07 11:06:08 +01:00
DRracer
a7dfe4b523
Merge pull request #3305 from gudnimg/sd-card-lcdtimer-fix-gudni-v2
...
Fix issue when the SD card is inserted and the file menu may sometimes close immediately due to a timeout
2021-11-19 07:23:21 +01:00
DRracer
3228f9d03c
Merge pull request #3304 from gudnimg/gudni-fix-compile-issue-v2
...
Fix build error when `TMC2130_SERVICE_CODES_M910_M918` is enabled
2021-11-19 07:21:38 +01:00
Guðni Már Gilbert
be79e3791f
Fixes #3262
...
Make sure to call lcd_timeoutToStatus.start() when the SD card is inserted
into the printer after it was removed beforehand.
(cherry picked from commit 6795843f153aa064f087f80990419a946cdfe857)
2021-11-18 19:23:21 +00:00
Guðni Már Gilbert
13732f162b
Fix build error when TMC2130_SERVICE_CODES_M910_M918 is enabled
...
(cherry picked from commit 6ed4b79cc6685f31b6914881008e036424dab2eb)
2021-11-18 19:19:56 +00:00
Guðni Már Gilbert
6887f844d3
Merge branch 'prusa3d:MK3' into fix-pinda-thermistor-build-fail
2021-11-18 19:15:15 +00:00
DRracer
bb9ba95bfc
Merge pull request #3303 from Panayiotis-git/MK3_3.10.1
...
Print temperatures only if filament loading is still active
2021-11-18 11:59:05 +01:00
Panayiotis-git
f8410d8f3c
Print temperatures only if filament loading is still active
2021-11-18 11:46:36 +02:00
DRracer
98d4e6972a
Merge pull request #3271 from dweekly/patch-1
...
Fix typos & small grammar changes
2021-11-18 08:50:04 +01:00
DRracer
13f0f4d85a
Merge pull request #3291 from EV3R4/typo-m84-docs
...
Typo: M84 docs
2021-11-18 08:46:25 +01:00
DRracer
e9fe7607a7
Merge pull request #3082 from awenelo/fix-bug-template
...
Keep consistent formatting for issue template
2021-11-18 08:43:14 +01:00
Guðni Már Gilbert
05e0c1e1d3
Fix build error if PINDA_THERMISTOR is not defined
...
temp_cal_active variable is not defined in this scope
2021-10-12 21:52:19 +00:00
EV3R4
eff9cd9f21
Typo: M84 docs
2021-09-27 19:34:53 +02:00
David E. Weekly
b37e289a8f
Fix typos & small grammar changes
...
Applied some gentle love to make this read better to a native English speaker. No meaningful change in content.
2021-08-22 12:25:50 -07:00
Guðni Már Gilbert
cf8a16baa1
Remove one call to lcd_timeoutToStatus.start
...
Saves 8 bytes of Flash memory
This call is redundant and when moving between menus
it gets called multiple times which results in waste
of clock cycles.
lcd_timeoutToStatus.start() is called from menu_lcd_lcdupdate_func()
which is enough.
2021-08-21 14:34:02 +00:00
Guðni Már Gilbert
e6a7abf2c1
Change temp_runaway_timer from float to uint32_t
...
Saves 32 bytes of flash
Also change temp_runaway_error_counter from int to
uint16_t to be specific
2021-08-06 15:08:46 +00:00
Guðni Már Gilbert
db1e5a203b
Change temp_runaway_status from float to uint8_t and its enum
...
Saves 90 bytes of flash, and 12 bytes of SRAM
2021-08-06 15:03:35 +00:00
Guðni Már Gilbert
b716c208d7
Various optimisation to change int to uint8_t
...
This commit saves 174 bytes of flash memory
2021-08-03 22:42:01 +00:00
Guðni Már Gilbert
8d7d1698ee
Remove unused global variable 'chunkHead'
...
No change in memory on my end, but it is one less 'int' :)
2021-08-03 21:48:26 +00:00
Guðni Már Gilbert
1946c58d21
1. Remove redundant variable 'inters'
...
2. 'gh' variable can be 1 byte instead of 2
This saves 26 bytes of flash memory
2021-08-03 21:46:11 +00:00
Guðni Már Gilbert
05ed5b9668
Improve lcd_selftest_screen_step() parameter types
...
Saves 62 bytes of flash memory
2021-08-03 21:35:28 +00:00
Guðni Már Gilbert
a54a133968
Use memset instead of nested for-loop to zero a 2d array
...
Saves 26 bytes of flash memory and removes two 'int' types
2021-08-02 19:20:51 +00:00
Guðni Már Gilbert
2554d21925
Use uint8_t when using axis enum
...
Saves 76 bytes of flash memory
2021-08-02 12:20:10 +00:00
DRracer
3bf5d937a8
Merge pull request #3192 from 3d-gussner/PFW-1271_PF-buildv20
...
PFW-1271 PF-build v2.0.0
2021-08-02 08:55:57 +02:00
DRracer
fd6dbba06f
Merge branch 'MK3_3.10.1' into PFW-1271_PF-buildv20
2021-08-02 08:51:51 +02:00
3d-gussner
da910fe861
Switch to arduino_boards v1.0.4
2021-08-02 08:34:35 +02:00
Guðni Már Gilbert
158877e736
Remove one space from Support -> Temperatures menu
...
Saves 2 bytes of flash memory
2021-08-01 11:20:29 +00:00
Guðni Már Gilbert
da2c802440
Add two defines and use LCD_STR_DEGREE with consistency
...
This saves 12 bytes of flash and 2 bytes of SRAM
2021-08-01 11:10:03 +00:00
Guðni Már Gilbert
6afc87d3c8
Reduce unnecessary LCD CGRAM writes
2021-07-30 23:53:57 +00:00
Yuri D'Elia
4f40380474
tools: document functions in utils.gdb
2021-07-30 06:38:12 +02:00
Yuri D'Elia
1b22aac9fc
tools: add xfimg2dump
2021-07-30 06:38:12 +02:00
Yuri D'Elia
a697d00647
tools: add __pycache__ to gitignore
2021-07-30 06:38:12 +02:00
Yuri D'Elia
c79b1dcbfa
tools: add dump_crash to recover XFLASH crash dumps
2021-07-30 06:38:12 +02:00
Yuri D'Elia
8455c8e585
tools: Add/fix documentation
2021-07-30 06:38:12 +02:00
Yuri D'Elia
43b9a2d3df
dump: do not hard-code constants
2021-07-30 06:38:12 +02:00
Yuri D'Elia
11a6ac2f4f
dump parsing: refuse to continue on incomplete D23 dumps
...
We should try harder to handle incomplete D21/D23 dumps in the future,
but until D21 handled too, bail in D23 as well.
2021-07-30 06:38:12 +02:00
Yuri D'Elia
500515eb0a
Add GDB utility functions to load/inspect binary dumps
2021-07-30 06:38:12 +02:00
Yuri D'Elia
06eab4ac11
Handle XFLASH (D21) and serial (D23) dumps in elf_mem_map, add dump2bin
...
- Uniformly parse D2/D21/D23 dump types.
- Add dump2bin to parse/convert a dump into metadata and binary.
- Move the parsing into it's own module in order to be shared.
2021-07-30 06:38:12 +02:00
Yuri D'Elia
9f40fa6834
elf_mem_map: parse D23 output directly
2021-07-30 06:38:12 +02:00
Yuri D'Elia
8ec4104840
elf_mem_map: do not output registers in qdirstat output
2021-07-30 06:38:12 +02:00