Alex Voinea
670214a30b
Fix indentation
2022-02-06 11:01:35 +01:00
Guðni Már Gilbert
c6ecc0dfc9
Merge branch 'prusa3d:MK3' into lcd-optimisation-gudni
2022-02-06 09:54:58 +00:00
Guðni Már Gilbert
c2bad473dc
Optimise _menu_edit_P
...
If the first if statement is true, then we don't need to check the next if statement.
Saves 64 bytes of flash memory
2022-02-06 09:01:16 +00:00
Alex Voinea
70cb30208c
Also change MUL24x24R24 to the new format and fix rounding
2022-02-06 01:11:22 +01:00
Alex Voinea
d06e74dd6f
Fix Welcome message and language flashing
2022-02-05 23:44:24 +01:00
Guðni Már Gilbert
a22a7ea9d7
Change LCD_STR_UPLEVEL to LCD_STR_UPLEVEL[0] for consistency
...
Saves 4 bytes of flash and 2 bytes of SRAM (Arduino IDE 1.8.19)
2022-02-05 19:58:31 +00:00
Guðni Már Gilbert
d5b666d260
Add LCD_STR_SOLID_BLOCK to represent \xFF
2022-02-05 19:53:42 +00:00
Guðni Már Gilbert
976c8c4902
Change message from .c to .cpp
...
The allows us to include lcd.h and replace hardcoded value with define LCD_STR_REFRESH
Also deleted a #define for bool which does not seem to be used.
2022-02-05 18:57:18 +00:00
Guðni Már Gilbert
e62bc4686f
Replace hardcoded values and optimise strings
...
This commit saves 64 bytes of flash memory on my end
2022-02-05 18:28:17 +00:00
Guðni Már Gilbert
19dc05597d
Fix identation in PR
...
Also combined the if statements that check farm_mode
If farm_mode is 0xFF then we can skip the next if statment.
No change in memory footprint
2022-02-05 11:24:04 +00:00
Alex Voinea
274f198188
Fix typo from long ago
2022-02-04 16:28:49 +01:00
Alex Voinea
58867f6c06
Fix arduino 1.8.13 warnings
2022-02-04 15:53:49 +01:00
Alex Voinea
f068c3258f
Pack endstop flags
2022-02-04 15:24:43 +01:00
Alex Voinea
21a0b53647
remove firstrun
2022-02-04 13:27:43 +01:00
Alex Voinea
858984ef35
SD sorting entries instead of positions
2022-02-04 10:47:56 +01:00
Guðni Már Gilbert
1f3640ab26
Merge branch 'MK3_3.12_Optimizations' of https://github.com/leptun/Prusa-Firmware into MK3_3.12_Optimizations
2022-02-02 20:49:41 +00:00
Guðni Már Gilbert
43bf33e791
Optimise usage of code_value()
...
code_value() is float but in some cases we can save memory when the expected output is only 1 or 2 bytes.
Changes save 182 bytes of flash memory on my end.
2022-02-02 20:48:36 +00:00
Alex Voinea
f25bddce35
Simplify GETPC()
2022-02-02 21:06:58 +01:00
Alex Voinea
6ce7792045
Remove "hh" in fmt where it makes no difference
2022-02-02 20:58:21 +01:00
Guðni Már Gilbert
146b008186
Remove redundant variable farm_status
...
It is unused and status_number variable can be used instead.
2022-02-02 18:37:55 +00:00
Guðni Már Gilbert
459570ab66
Change prusa_stat_printerstatus parameter to uint8_t
...
Also changes status_number global variable to uint8_t
Changes save 80 bytes of flash and 1 byte of SRAM (Arduino IDE 1.8.19)
2022-02-02 18:35:52 +00:00
Guðni Már Gilbert
e525bcb7f5
Optimise lcd_selftest_screen input parameters and return type
...
* _progress_scale is max 3 so it can be uint8_t
* _progress is max 6 so it can be uint8_t
* Change _delay type to uint16_t to be explicit
Changes save 102 bytes of flash memory (Arduino IDE 1.8.19)
2022-02-01 18:57:43 +00:00
Guðni Már Gilbert
8681d84c44
Merge branch 'MK3_3.12_Optimizations' of https://github.com/leptun/Prusa-Firmware into MK3_3.12_Optimizations
2022-02-01 18:37:57 +00:00
Guðni Már Gilbert
53dfcf9d6f
Optimise if-statments in world2machine_clamp
...
Only one of the statements can be true: tmpx < X_MIN_POS or tmpx > X_MAX_POS.
So we can be a little bit smarter here and skip the second if statement if the first was true.
This saves 6 bytes of flash memory and potential some clock cycles
2022-02-01 18:37:41 +00:00
Alex Voinea
aec2db7683
Optimize MUL8x16R8
2022-02-01 18:12:13 +01:00
Guðni Már Gilbert
c0e7e17fc3
Fix type of nrFiles
2022-01-30 13:07:09 +00:00
Alex Voinea
1523194d3b
Fix build (merge conflict)
2022-01-30 13:18:07 +01:00
Alex Voinea
67e6361ff1
Fix temperature runaway variable types (merge conflict)
2022-01-30 13:16:05 +01:00
Guðni Már Gilbert
9bf45773f9
Merge remote-tracking branch 'upstream/MK3' into rebase-testing-ground-v2
2022-01-30 11:43:16 +00:00
Alex Voinea
0f5312f927
Merge pull request #8 from gudnimg/remove-unused-var-gudni
...
Remove unused variables
Shrink integer types where possible
2022-01-30 11:39:29 +00:00
Alex Voinea
aae562e480
Fix G81 for loop
2022-01-30 11:39:29 +00:00
Guðni Már Gilbert
c081e1a5ae
Loop index can be unsigned
...
Saves 4 bytes of flash memory
2022-01-30 11:39:29 +00:00
Guðni Már Gilbert
49693a9fb3
Remove undefined function
...
No change in memory footprint.
2022-01-30 11:39:29 +00:00
Alex Voinea
d69b8daa72
Merge pull request #7 from gudnimg/gudni-PR2
...
Save some memory by using memset and inlined memcpy
2022-01-30 11:39:28 +00:00
Guðni Már Gilbert
c705d4aa10
Change set_z() parameters to uin8_t
...
Saves 24 bytes of flash
2022-01-30 11:39:28 +00:00
Guðni Már Gilbert
581188ce2c
Fix an issue found in code review
...
Unfortunately this increases flash usages by 212 bytes (same usage as in current release) It seems it is most memory effcient to use int16_t (int). int8_t requires more memory.
2022-01-30 11:39:28 +00:00
Guðni Már Gilbert
f8847edca6
Remove one unused variable
...
Saves 1 byte of SRAM
The variable is only assigned a value but is never used.
2022-01-30 11:39:28 +00:00
Guðni Már Gilbert
d8723c0eac
Use code_value_uint8() in get_command()
...
The if statement is simplified as the value is never negative
and we can get rid of one variable
Saves 12 bytes of flash memory
2022-01-30 11:39:27 +00:00
Guðni Már Gilbert
ac049c7e3c
Use code_value_short() in get_command()
...
Same code but uses a defined function
Saves 28 bytes of flash memory
2022-01-30 11:39:27 +00:00
Guðni Már Gilbert
052ecc3782
G81: Change for loop variables x and y to uint8_t
...
Saves 198 bytes of flash, that's crazy
2022-01-30 11:39:27 +00:00
Guðni Már Gilbert
7787f17139
Smaller code in G28
...
Replace two blocks of code with already defined functions.
Change saves 100 bytes of flash memory and 11 lines of code.
2022-01-30 11:39:27 +00:00
Guðni Már Gilbert
b835f31904
Remove variable move_menu_scale
...
The variable is just set to 1.0 and is never modified, I also
removed the function lcd_move_menu_1mm()
Changes save 96 bytes of flash memory and 4 bytes of SRAM
2022-01-30 11:39:27 +00:00
Guðni Már Gilbert
a940c364c9
Create enum class for heating_status variable
2022-01-30 11:39:27 +00:00
Guðni Már Gilbert
2013295f94
Change farm_timer to uint8_t
...
Remove extern declaration of farm_timer and farm_status as they
are only used in one file.
Saves 26 bytes of flash
2022-01-30 11:39:26 +00:00
Guðni Már Gilbert
a687173e02
Change custom_message_state_old and custom_message_state to uint8_t
...
I see max value as 7*7+10 = 59
Saves 100 byte of flash and 1 byte of SRAM
2022-01-30 11:39:26 +00:00
Guðni Már Gilbert
60c9640602
Change heating_status_counter to uint8_t
...
It has a max value of 14
Saves 28 bytes of flash and 1 byte of SRAM
2022-01-30 11:39:26 +00:00
Guðni Már Gilbert
22f23dff36
Change heating_status to uint8_t
...
Saves 66 byte of flash and 1 byte of SRAM
2022-01-30 11:39:26 +00:00
Guðni Már Gilbert
2d614a8d41
Change usb_printing_counter to uint8_t
...
It is assigned max value of 10
Saves 26 byte of flash and 1 byte of SRAM
2022-01-30 11:39:26 +00:00
Guðni Már Gilbert
aa0a86bf13
Remove internal Prusa command 'Beat'
...
It doesn't seem to do anything.
Saves 22 bytes of flash
2022-01-30 11:39:25 +00:00
Guðni Már Gilbert
42778cae83
Remove unused kicktime timer
...
The variable is only set and never actually used
Saves 8 bytes of flash and 4 bytes of SRAM
2022-01-30 11:39:25 +00:00