Tiny changes in the new Duet3D dsf support code
This commit is contained in:
parent
daeb618812
commit
197d2b968c
@ -177,6 +177,8 @@ void Duet::disconnect(ConnectionType connectionType) const
|
||||
|
||||
std::string Duet::get_upload_url(const std::string &filename, ConnectionType connectionType) const
|
||||
{
|
||||
assert(connectionType != ConnectionType::error);
|
||||
|
||||
if (connectionType == ConnectionType::dsf) {
|
||||
return (boost::format("%1%machine/file/gcodes/%2%")
|
||||
% get_base_url()
|
||||
@ -230,6 +232,8 @@ std::string Duet::timestamp_str() const
|
||||
|
||||
bool Duet::start_print(wxString &msg, const std::string &filename, ConnectionType connectionType) const
|
||||
{
|
||||
assert(connectionType != ConnectionType::error);
|
||||
|
||||
bool res = false;
|
||||
bool dsf = (connectionType == ConnectionType::dsf);
|
||||
|
||||
|
@ -14,7 +14,7 @@ class Http;
|
||||
class Duet : public PrintHost
|
||||
{
|
||||
public:
|
||||
Duet(DynamicPrintConfig *config);
|
||||
explicit Duet(DynamicPrintConfig *config);
|
||||
~Duet() override = default;
|
||||
|
||||
const char* get_name() const override;
|
||||
|
@ -120,7 +120,7 @@ struct Http::priv
|
||||
std::string error_buffer; // Used for CURLOPT_ERRORBUFFER
|
||||
size_t limit;
|
||||
bool cancel;
|
||||
fs::ifstream* putFile;
|
||||
std::unique_ptr<fs::ifstream> putFile;
|
||||
|
||||
std::thread io_thread;
|
||||
Http::CompleteFn completefn;
|
||||
@ -298,8 +298,8 @@ void Http::priv::set_put_body(const fs::path &path)
|
||||
boost::system::error_code ec;
|
||||
boost::uintmax_t filesize = file_size(path, ec);
|
||||
if (!ec) {
|
||||
putFile = new fs::ifstream(path);
|
||||
::curl_easy_setopt(curl, CURLOPT_READDATA, (void *) (putFile));
|
||||
putFile = std::make_unique<fs::ifstream>(path);
|
||||
::curl_easy_setopt(curl, CURLOPT_READDATA, (void *) (putFile.get()));
|
||||
::curl_easy_setopt(curl, CURLOPT_INFILESIZE, filesize);
|
||||
}
|
||||
}
|
||||
@ -355,10 +355,7 @@ void Http::priv::http_perform()
|
||||
|
||||
CURLcode res = ::curl_easy_perform(curl);
|
||||
|
||||
if (putFile != nullptr) {
|
||||
delete putFile;
|
||||
putFile = nullptr;
|
||||
}
|
||||
putFile.reset();
|
||||
|
||||
if (res != CURLE_OK) {
|
||||
if (res == CURLE_ABORTED_BY_CALLBACK) {
|
||||
@ -398,6 +395,7 @@ Http::Http(Http &&other) : p(std::move(other.p)) {}
|
||||
|
||||
Http::~Http()
|
||||
{
|
||||
assert(! putFile);
|
||||
if (p && p->io_thread.joinable()) {
|
||||
p->io_thread.detach();
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user