3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use correct encoding when calling external updater

Browse Source
This commit is contained in:
Lukas Matena 2021-11-03 10:57:45 +01:00 committed by David Kocik
parent 9994e0bcbc
commit 262304c777
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/PrusaSlicer.cpp
View File

@ -679,14 +679,18 @@ bool CLI::setup(int argc, char **argv)
#ifdef _WIN32
// find updater exe
for (auto& dir_entry : boost::filesystem::directory_iterator(path_to_binary.parent_path())) {
for (const auto& dir_entry : boost::filesystem::directory_iterator(path_to_binary.parent_path())) {
if (dir_entry.path().filename() == "prusaslicer-updater.exe") {
// run updater. Original args: /silent -restartapp prusa-slicer.exe -startappfirst
std::string args = dir_entry.path().string();
args += " /silent";
// Using quoted string as mentioned in CreateProcessW docs.
std::wstring wcmd = L"\"" + dir_entry.path().wstring() + L"\"";
wcmd += L" /silent";
// additional information
STARTUPINFOA si;
STARTUPINFOW si;
PROCESS_INFORMATION pi;
// set the size of the structures
@ -695,8 +699,8 @@ bool CLI::setup(int argc, char **argv)
ZeroMemory(&pi, sizeof(pi));
// start the program up
CreateProcessA(NULL, // the path
const_cast<char*>(args.c_str()), // Command line
if (CreateProcessW(NULL, // the path
wcmd.data(), // Command line
NULL, // Process handle not inheritable
NULL, // Thread handle not inheritable
FALSE, // Set handle inheritance to FALSE
@ -705,11 +709,11 @@ bool CLI::setup(int argc, char **argv)
NULL, // Use parent's starting directory
&si, // Pointer to STARTUPINFO structure
&pi // Pointer to PROCESS_INFORMATION structure (removed extra parentheses)
);
// Close process and thread handles.
CloseHandle(pi.hProcess);
CloseHandle(pi.hThread);
)) {
// Close process and thread handles.
CloseHandle(pi.hProcess);
CloseHandle(pi.hThread);
}
break;
}
}