From 2689f49ef8845ba65394e63e0608a80fd21f6986 Mon Sep 17 00:00:00 2001 From: Mark Hindess Date: Thu, 31 May 2012 18:15:40 +0100 Subject: [PATCH] Remove grep that is effectively repeated. --- lib/Slic3r/TriangleMesh.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/Slic3r/TriangleMesh.pm b/lib/Slic3r/TriangleMesh.pm index 75180beec..795c4ec4a 100644 --- a/lib/Slic3r/TriangleMesh.pm +++ b/lib/Slic3r/TriangleMesh.pm @@ -127,9 +127,10 @@ sub clean { sub check_manifoldness { my $self = shift; - # look for edges not connected to exactly two facets - if (grep { @$_ != 2 } @{$self->edges_facets}) { - my ($first_bad_edge_id) = grep { @{ $self->edges_facets->[$_] } != 2 } 0..$#{$self->edges_facets}; + # look for any edges not connected to exactly two facets + my ($first_bad_edge_id) = + grep { @{ $self->edges_facets->[$_] } != 2 } 0..$#{$self->edges_facets}; + if (defined $first_bad_edge_id) { warn sprintf "Warning: The input file is not manifold near edge %f-%f. " . "You might want to check the resulting G-code before printing.\n", @{$self->edges->[$first_bad_edge_id]};