From 34821df6eb119b725c6e05596a4e73d3d6c69d37 Mon Sep 17 00:00:00 2001 From: Vojtech Kral Date: Fri, 6 Sep 2019 14:50:44 +0200 Subject: [PATCH] Fix bad pointer dereference in ObjectList::list_manipulation() Fix of #2875 --- src/slic3r/GUI/GUI_ObjectList.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/slic3r/GUI/GUI_ObjectList.cpp b/src/slic3r/GUI/GUI_ObjectList.cpp index 20760e2bc..7ba26f471 100644 --- a/src/slic3r/GUI/GUI_ObjectList.cpp +++ b/src/slic3r/GUI/GUI_ObjectList.cpp @@ -789,16 +789,11 @@ void ObjectList::OnContextMenu(wxDataViewEvent&) void ObjectList::list_manipulation() { wxDataViewItem item; - wxDataViewColumn* col; + wxDataViewColumn* col = nullptr; const wxPoint pt = get_mouse_position_in_control(); HitTest(pt, item, col); -#ifdef __WXOSX__ // temporary workaround for OSX - // after Yosemite OS X version, HitTest return undefined item - if (!item) item = GetSelection(); -#endif // __WXOSX__ - if (!item) { - printf("undefined item\n"); + if (!item || col == nullptr) { return; }