From 399fc519e63c429d384cb8f08e61627e7c7f1eeb Mon Sep 17 00:00:00 2001
From: Alessandro Ranellucci <aar@cpan.org>
Date: Sat, 22 Nov 2014 22:52:12 +0100
Subject: [PATCH] Leave the Spiral Vase checkbox always enabled but prompt user
 when incompatible options are set. This should be more user-friendly than
 blindly disabling the Spiral Vase checkbox. #2360

---
 lib/Slic3r/GUI/Tab.pm | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/lib/Slic3r/GUI/Tab.pm b/lib/Slic3r/GUI/Tab.pm
index 204cfe30d..a992195b3 100644
--- a/lib/Slic3r/GUI/Tab.pm
+++ b/lib/Slic3r/GUI/Tab.pm
@@ -418,6 +418,8 @@ sub set_value {
 package Slic3r::GUI::Tab::Print;
 use base 'Slic3r::GUI::Tab';
 
+use Wx qw(:icon :dialog :id);
+
 sub name { 'print' }
 sub title { 'Print Settings' }
 
@@ -693,13 +695,21 @@ sub _update {
     
     my $config = $self->{config};
     
-    # we enable spiral vase if other settings are compatible with it
-    # or if it is enabled (this prevents the checkbox from being disabled
-    # when an incompatible setting is set)
-    $self->get_field('spiral_vase')->toggle(
-        ($config->perimeters == 1 && $config->top_solid_layers == 0 && $config->fill_density == 0)
-            || $config->spiral_vase
-    );
+    if ($config->spiral_vase && !($config->perimeters == 1 && $config->top_solid_layers == 0 && $config->fill_density == 0)) {
+        my $dialog = Wx::MessageDialog->new($self, "The Spiral Vase mode requires one perimeter, no top solid layers and 0% fill density. Shall I adjust those settings in order to enable Spiral Vase?",
+            'Spiral Vase', wxICON_WARNING | wxYES | wxNO);
+        if ($dialog->ShowModal() == wxID_YES) {
+            my $new_conf = Slic3r::Config->new;
+            $new_conf->set("perimeters", 1);
+            $new_conf->set("top_solid_layers", 0);
+            $new_conf->set("fill_density", 0);
+            $self->load_config($new_conf);
+        } else {
+            my $new_conf = Slic3r::Config->new;
+            $new_conf->set("spiral_vase", 0);
+            $self->load_config($new_conf);
+        }
+    }
     
     my $have_perimeters = $config->perimeters > 0;
     $self->get_field($_)->toggle($have_perimeters)