Unify Tree/Organic terminology.

+ Implemented Enabling/Disabling for parameters of Organic support
SPE-1478(https://dev.prusa3d.com/browse/SPE-1478)
This commit is contained in:
YuSanka 2023-02-14 10:18:06 +01:00
parent a9221c3c5b
commit 4162689a65
3 changed files with 17 additions and 10 deletions

View File

@ -2786,7 +2786,7 @@ void PrintConfigDef::init_fff_params()
def->set_default_value(new ConfigOptionBool(true)); def->set_default_value(new ConfigOptionBool(true));
def = this->add("support_tree_angle", coFloat); def = this->add("support_tree_angle", coFloat);
def->label = L("Tree Support Maximum Branch Angle"); def->label = L("Maximum Branch Angle");
def->category = L("Support material"); def->category = L("Support material");
def->tooltip = L("The maximum angle of the branches, when the branches have to avoid the model. " def->tooltip = L("The maximum angle of the branches, when the branches have to avoid the model. "
"Use a lower angle to make them more vertical and more stable. Use a higher angle to be able to have more reach."); "Use a lower angle to make them more vertical and more stable. Use a higher angle to be able to have more reach.");
@ -2797,7 +2797,7 @@ void PrintConfigDef::init_fff_params()
def->set_default_value(new ConfigOptionFloat(40)); def->set_default_value(new ConfigOptionFloat(40));
def = this->add("support_tree_angle_slow", coFloat); def = this->add("support_tree_angle_slow", coFloat);
def->label = L("Tree Support Preferred Branch Angle"); def->label = L("Preferred Branch Angle");
def->category = L("Support material"); def->category = L("Support material");
def->tooltip = L("The preferred angle of the branches, when they do not have to avoid the model. " def->tooltip = L("The preferred angle of the branches, when they do not have to avoid the model. "
"Use a lower angle to make them more vertical and more stable. Use a higher angle for branches to merge faster."); "Use a lower angle to make them more vertical and more stable. Use a higher angle for branches to merge faster.");
@ -2808,18 +2808,18 @@ void PrintConfigDef::init_fff_params()
def->set_default_value(new ConfigOptionFloat(25)); def->set_default_value(new ConfigOptionFloat(25));
def = this->add("support_tree_tip_diameter", coFloat); def = this->add("support_tree_tip_diameter", coFloat);
def->label = L("Tree Support Tip Diameter"); def->label = L("Tip Diameter");
def->category = L("Support material"); def->category = L("Support material");
def->tooltip = L("The diameter of the top of the tip of the branches of tree support."); def->tooltip = L("The diameter of the top of the tip of the branches of organic support.");
def->sidetext = L("mm"); def->sidetext = L("mm");
def->min = 0; def->min = 0;
def->mode = comAdvanced; def->mode = comAdvanced;
def->set_default_value(new ConfigOptionFloat(0.8)); def->set_default_value(new ConfigOptionFloat(0.8));
def = this->add("support_tree_branch_diameter", coFloat); def = this->add("support_tree_branch_diameter", coFloat);
def->label = L("Tree Support Branch Diameter"); def->label = L("Branch Diameter");
def->category = L("Support material"); def->category = L("Support material");
def->tooltip = L("The diameter of the thinnest branches of tree support. Thicker branches are more sturdy. " def->tooltip = L("The diameter of the thinnest branches of organic support. Thicker branches are more sturdy. "
"Branches towards the base will be thicker than this."); "Branches towards the base will be thicker than this.");
def->sidetext = L("mm"); def->sidetext = L("mm");
def->min = 0; def->min = 0;
@ -2827,11 +2827,11 @@ void PrintConfigDef::init_fff_params()
def->set_default_value(new ConfigOptionFloat(2)); def->set_default_value(new ConfigOptionFloat(2));
def = this->add("support_tree_branch_diameter_angle", coFloat); def = this->add("support_tree_branch_diameter_angle", coFloat);
def->label = L("Tree Support Branch Diameter Angle"); def->label = L("Branch Diameter Angle");
def->category = L("Support material"); def->category = L("Support material");
def->tooltip = L("The angle of the branches' diameter as they gradually become thicker towards the bottom. " def->tooltip = L("The angle of the branches' diameter as they gradually become thicker towards the bottom. "
"An angle of 0 will cause the branches to have uniform thickness over their length. " "An angle of 0 will cause the branches to have uniform thickness over their length. "
"A bit of an angle can increase stability of the tree support."); "A bit of an angle can increase stability of the organic support.");
def->sidetext = L("°"); def->sidetext = L("°");
def->min = 0; def->min = 0;
def->max = 15; def->max = 15;
@ -2839,7 +2839,7 @@ void PrintConfigDef::init_fff_params()
def->set_default_value(new ConfigOptionFloat(5)); def->set_default_value(new ConfigOptionFloat(5));
def = this->add("support_tree_top_rate", coPercent); def = this->add("support_tree_top_rate", coPercent);
def->label = L("Tree Support Branch Density"); def->label = L("Branch Density");
def->category = L("Support material"); def->category = L("Support material");
def->tooltip = L("Adjusts the density of the support structure used to generate the tips of the branches. " def->tooltip = L("Adjusts the density of the support structure used to generate the tips of the branches. "
"A higher value results in better overhangs, but the supports are harder to remove. " "A higher value results in better overhangs, but the supports are harder to remove. "

View File

@ -292,6 +292,13 @@ void ConfigManipulation::toggle_print_fff_options(DynamicPrintConfig* config)
toggle_field("support_material_bottom_contact_distance", have_support_material && ! have_support_soluble); toggle_field("support_material_bottom_contact_distance", have_support_material && ! have_support_soluble);
toggle_field("support_material_closing_radius", have_support_material && support_material_style == smsSnug); toggle_field("support_material_closing_radius", have_support_material && support_material_style == smsSnug);
const bool has_organic_supports = support_material_style == smsOrganic &&
(config->opt_bool("support_material") ||
config->opt_int("support_material_enforce_layers") > 0);
for (const std::string& key : { "support_tree_angle", "support_tree_angle_slow", "support_tree_branch_diameter",
"support_tree_branch_diameter_angle", "support_tree_tip_diameter", "support_tree_top_rate" })
toggle_field(key, has_organic_supports);
for (auto el : { "support_material_bottom_interface_layers", "support_material_interface_spacing", "support_material_interface_extruder", for (auto el : { "support_material_bottom_interface_layers", "support_material_interface_spacing", "support_material_interface_extruder",
"support_material_interface_speed", "support_material_interface_contact_loops" }) "support_material_interface_speed", "support_material_interface_contact_loops" })
toggle_field(el, have_support_material && have_support_interface); toggle_field(el, have_support_material && have_support_interface);

View File

@ -1526,7 +1526,7 @@ void TabPrint::build()
optgroup->append_single_option_line("dont_support_bridges", category_path + "dont-support-bridges"); optgroup->append_single_option_line("dont_support_bridges", category_path + "dont-support-bridges");
optgroup->append_single_option_line("support_material_synchronize_layers", category_path + "synchronize-with-object-layers"); optgroup->append_single_option_line("support_material_synchronize_layers", category_path + "synchronize-with-object-layers");
optgroup = page->new_optgroup(L("Tree supports")); optgroup = page->new_optgroup(L("Organic supports"));
optgroup->append_single_option_line("support_tree_angle", category_path + "tree_angle"); optgroup->append_single_option_line("support_tree_angle", category_path + "tree_angle");
optgroup->append_single_option_line("support_tree_angle_slow", category_path + "tree_angle_slow"); optgroup->append_single_option_line("support_tree_angle_slow", category_path + "tree_angle_slow");
optgroup->append_single_option_line("support_tree_branch_diameter", category_path + "tree_branch_diameter"); optgroup->append_single_option_line("support_tree_branch_diameter", category_path + "tree_branch_diameter");