3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash in GUI caused by recursive event calls. #2613

Browse Source
This commit is contained in:
Alessandro Ranellucci 2015-06-01 23:11:27 +02:00
parent 6095427926
commit 4402dfa6f3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Slic3r/GUI/Tab.pm
View File

@ -65,7 +65,9 @@ sub new {
$self->{treectrl}->AddRoot("root"); $self->{treectrl}->AddRoot("root");
$self->{pages} = []; $self->{pages} = [];
$self->{treectrl}->SetIndent(0); $self->{treectrl}->SetIndent(0);
$self->{disable_tree_sel_changed_event} = 0;
EVT_TREE_SEL_CHANGED($parent, $self->{treectrl}, sub { EVT_TREE_SEL_CHANGED($parent, $self->{treectrl}, sub {
return if $self->{disable_tree_sel_changed_event};
my $page = first { $_->{title} eq $self->{treectrl}->GetItemText($self->{treectrl}->GetSelection) } @{$self->{pages}} my $page = first { $_->{title} eq $self->{treectrl}->GetItemText($self->{treectrl}->GetSelection) } @{$self->{pages}}
or return; or return;
$_->Hide for @{$self->{pages}}; $_->Hide for @{$self->{pages}};
@ -303,12 +305,15 @@ sub update_tree {
foreach my $page (@{$self->{pages}}) { foreach my $page (@{$self->{pages}}) {
my $itemId = $self->{treectrl}->AppendItem($rootItem, $page->{title}, $page->{iconID}); my $itemId = $self->{treectrl}->AppendItem($rootItem, $page->{title}, $page->{iconID});
if ($page->{title} eq $selected) { if ($page->{title} eq $selected) {
$self->{disable_tree_sel_changed_event} = 1;
$self->{treectrl}->SelectItem($itemId); $self->{treectrl}->SelectItem($itemId);
$self->{disable_tree_sel_changed_event} = 0;
$have_selection = 1; $have_selection = 1;
} }
} }
if (!$have_selection) { if (!$have_selection) {
# this is triggered on first load, so we don't disable the sel change event
$self->{treectrl}->SelectItem($self->{treectrl}->GetFirstChild($rootItem)); $self->{treectrl}->SelectItem($self->{treectrl}->GetFirstChild($rootItem));
} }
} }