3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't trigger extra perimeters when less than 30% of the upper loops would benefit from it. #2664. Also fixes #2610

Browse source
This commit is contained in:
Alessandro Ranellucci 2015-02-24 00:34:43 +01:00
parent 7a695a4a2f
commit 45c91b2ae9
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
lib/Slic3r/Print/Object.pm
View file

@ -398,15 +398,26 @@ sub make_perimeters {
# check whether a portion of the upper slices falls inside the critical area
my $intersection = intersection_ppl(
[ map @{$_->expolygon}, @{$upper_layerm->slices} ],
[ map $_->p, @{$upper_layerm->slices} ],
$critical_area,
);
# ignore any intersection line that is shorter than three times the critical area depth
last if !defined first { $_->length > $critical_area_depth * 3 } @$intersection;
# only add an additional loop if at least 30% of the slice loop would benefit from it
my $total_loop_length = sum(map $_->length, map $_->p, @{$upper_layerm->slices}) // 0;
my $total_intersection_length = sum(map $_->length, @$intersection) // 0;
last unless $total_intersection_length > $total_loop_length*0.3;
if (0) {
require "Slic3r/SVG.pm";
Slic3r::SVG::output(
"extra.svg",
no_arrows => 1,
expolygons => union_ex($critical_area),
polylines => [ map $_->split_at_first_point, map $_->p, @{$upper_layerm->slices} ],
);
}
$slice->extra_perimeters($slice->extra_perimeters + 1);
}
Slic3r::debugf " adding %d more perimeter(s) at layer %d\n",
$slice->extra_perimeters, $layerm->id