From 605f0ecd54c9c363cb58223f5008eb4e90fd9449 Mon Sep 17 00:00:00 2001 From: Lukas Matena Date: Wed, 16 Oct 2019 12:53:25 +0200 Subject: [PATCH] Revert "CMakeLists.txt: turning off Wno-ignored-attributes on GCC and Clang again" That change breaks compilation on the old buildserver (gcc 5.4). We'll deal with the warning later somehow. This reverts commit 50448bf4dd178ce60b0e18aa2388ce29614715dc. --- CMakeLists.txt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3efc18b8e..7b1d73f89 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -174,10 +174,9 @@ if (NOT MSVC AND ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" OR "${CMAKE_CXX_COMP add_compile_options(-Werror=return-type) #removes LOTS of extraneous Eigen warnings (GCC only supports it since 6.1) - #https://eigen.tuxfamily.org/bz/show_bug.cgi?id=1221 - if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" OR CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 6.1) - add_compile_options(-Wno-ignored-attributes) - endif() + #if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" OR CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 6.1) + # add_compile_options(-Wno-ignored-attributes) # Tamas: Eigen include dirs are marked as SYSTEM + #endif() #GCC generates loads of -Wunknown-pragmas when compiling igl. The fix is not easy due to a bug in gcc, see # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66943 or