3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix wrong bridge flow used for overhangs and bridge perimeters. Includes regression test. #1407

Browse Source
This commit is contained in:
Alessandro Ranellucci 2013-09-17 10:36:06 +02:00
parent d13e7b264a
commit 7bd2ce21ca
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Slic3r/GCode.pm
View File

@ -225,7 +225,11 @@ sub extrude_loop {
# get overhang paths by intersecting overhangs with the loop # get overhang paths by intersecting overhangs with the loop
push @paths, push @paths,
map { $_->role(EXTR_ROLE_OVERHANG_PERIMETER); $_ } map {
$_->role(EXTR_ROLE_OVERHANG_PERIMETER);
$_->flow_spacing($self->extruder->bridge_flow->width);
$_
}
$extrusion_path->intersect_expolygons($self->_layer_overhangs_pp); $extrusion_path->intersect_expolygons($self->_layer_overhangs_pp);
# reapply the nearest point search for starting point # reapply the nearest point search for starting point

4
t/perimeters.t
View File

@ -103,10 +103,12 @@ use Slic3r::Test;
$config->set('fan_below_layer_time', 0); $config->set('fan_below_layer_time', 0);
$config->set('slowdown_below_layer_time', 0); $config->set('slowdown_below_layer_time', 0);
$config->set('bridge_fan_speed', 100); $config->set('bridge_fan_speed', 100);
$config->set('bridge_flow_ratio', 33); # arbitrary value
$config->set('overhangs', 1); $config->set('overhangs', 1);
my $print = Slic3r::Test::init_print('overhang', config => $config); my $print = Slic3r::Test::init_print('overhang', config => $config);
my %layer_speeds = (); # print Z => [ speeds ] my %layer_speeds = (); # print Z => [ speeds ]
my $fan_speed = 0; my $fan_speed = 0;
my $bridge_mm_per_mm = ($config->nozzle_diameter->[0]**2) / ($config->filament_diameter->[0]**2) * $config->bridge_flow_ratio;
Slic3r::GCode::Reader->new->parse(Slic3r::Test::gcode($print), sub { Slic3r::GCode::Reader->new->parse(Slic3r::Test::gcode($print), sub {
my ($self, $cmd, $args, $info) = @_; my ($self, $cmd, $args, $info) = @_;
@ -124,6 +126,8 @@ use Slic3r::Test;
if ($feedrate == $config->bridge_speed*60) { if ($feedrate == $config->bridge_speed*60) {
fail 'printing overhang but fan is not enabled or running at wrong speed' fail 'printing overhang but fan is not enabled or running at wrong speed'
if $fan_speed != 255; if $fan_speed != 255;
my $mm_per_mm = $info->{dist_E} / $info->{dist_XY};
fail 'wrong bridge flow' if abs($mm_per_mm - $bridge_mm_per_mm) > 0.01;
} else { } else {
fail 'fan is running when not supposed to' fail 'fan is running when not supposed to'
if $fan_speed > 0; if $fan_speed > 0;