From 50448bf4dd178ce60b0e18aa2388ce29614715dc Mon Sep 17 00:00:00 2001 From: Lukas Matena Date: Tue, 15 Oct 2019 15:10:52 +0200 Subject: [PATCH] CMakeLists.txt: turning off Wno-ignored-attributes on GCC and Clang again Eigen still produces tons of those warnings on newer gcc --- CMakeLists.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7b1d73f89..3efc18b8e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -174,9 +174,10 @@ if (NOT MSVC AND ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" OR "${CMAKE_CXX_COMP add_compile_options(-Werror=return-type) #removes LOTS of extraneous Eigen warnings (GCC only supports it since 6.1) - #if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" OR CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 6.1) - # add_compile_options(-Wno-ignored-attributes) # Tamas: Eigen include dirs are marked as SYSTEM - #endif() + #https://eigen.tuxfamily.org/bz/show_bug.cgi?id=1221 + if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" OR CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 6.1) + add_compile_options(-Wno-ignored-attributes) + endif() #GCC generates loads of -Wunknown-pragmas when compiling igl. The fix is not easy due to a bug in gcc, see # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66943 or