3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Bugfix: don't crash when skirts > 0 but skirt_height = 0. Includes regression test. #2537

Browse source
This commit is contained in:
Alessandro Ranellucci 2015-01-18 13:01:00 +01:00
parent 9f0283f808
commit 90afbc8bd9
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/Slic3r/Print.pm
View file

@ -203,7 +203,7 @@ sub make_skirt {
# checking whether we need to generate them # checking whether we need to generate them
$self->skirt->clear; $self->skirt->clear;
if ($self->config->skirts == 0 if (($self->config->skirts == 0 || $self->config->skirt_height == 0)
&& (!$self->config->ooze_prevention || @{$self->extruders} == 1)) { && (!$self->config->ooze_prevention || @{$self->extruders} == 1)) {
$self->set_step_done(STEP_SKIRT); $self->set_step_done(STEP_SKIRT);
return; return;

11
t/skirt_brim.t
View file

@ -1,4 +1,4 @@
use Test::More tests => 5; use Test::More tests => 6;
use strict; use strict;
use warnings; use warnings;
@ -79,6 +79,15 @@ use Slic3r::Test;
ok Slic3r::Test::gcode($print), 'successful G-code generation when skirt is smaller than brim width'; ok Slic3r::Test::gcode($print), 'successful G-code generation when skirt is smaller than brim width';
} }
{
my $config = Slic3r::Config->new_from_defaults;
$config->set('skirts', 1);
$config->set('skirt_height', 0);
my $print = Slic3r::Test::init_print('20mm_cube', config => $config);
ok Slic3r::Test::gcode($print), 'successful G-code generation when skirt_height = 0 and skirts > 0';
}
{ {
my $config = Slic3r::Config->new_from_defaults; my $config = Slic3r::Config->new_from_defaults;
$config->set('layer_height', 0.4); $config->set('layer_height', 0.4);