3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bugfix: custom seam identification

Browse Source 
Bounding boxes of polygons could overlap. Ask the AABB tree for all possible candidates.
Might be faster than searching for the closest triangle, that requires traversing the whole depth of the tree every time.
This commit is contained in:
Lukas Matena 2020-12-04 16:34:23 +01:00
parent 985a4a8bf3
commit 997ee971b4
2 changed files with 24 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/libslic3r/AABBTreeIndirect.hpp
View File

@ -730,13 +730,11 @@ inline bool is_any_triangle_in_radius(
// Traverse the tree and return the index of an entity whose bounding box
// contains a given point. Returns size_t(-1) when the point is outside.
template<typename TreeType, typename VectorType>
size_t get_candidate_idx(const TreeType& tree, const VectorType& v)
void get_candidate_idxs(const TreeType& tree, const VectorType& v, std::vector<size_t>& candidates, size_t node_idx = 0)
{
if (tree.empty() || ! tree.node(0).bbox.contains(v))
return size_t(-1);
if (tree.empty() || ! tree.node(node_idx).bbox.contains(v))
return;
size_t node_idx = 0;
while (true) {
decltype(tree.node(node_idx)) node = tree.node(node_idx);
static_assert(std::is_reference<decltype(node)>::value,
"Nodes shall be addressed by reference.");
@ -745,14 +743,13 @@ size_t get_candidate_idx(const TreeType& tree, const VectorType& v)
if (! node.is_leaf()) {
if (tree.left_child(node_idx).bbox.contains(v))
node_idx = tree.left_child_idx(node_idx);
else if (tree.right_child(node_idx).bbox.contains(v))
node_idx = tree.right_child_idx(node_idx);
else
return size_t(-1);
get_candidate_idxs(tree, v, candidates, tree.left_child_idx(node_idx));
if (tree.right_child(node_idx).bbox.contains(v))
get_candidate_idxs(tree, v, candidates, tree.right_child_idx(node_idx));
} else
return node.idx;
}
candidates.push_back(node.idx);
return;
}

10
src/libslic3r/GCode/SeamPlacer.cpp
View File

@ -569,10 +569,12 @@ void SeamPlacer::get_enforcers_and_blockers(size_t layer_id,
auto is_inside = [](const Point& pt,
const CustomTrianglesPerLayer& custom_data) -> bool {
assert(! custom_data.polys.empty());
// Now ask the AABB tree which polygon we should check and check it.
size_t candidate = AABBTreeIndirect::get_candidate_idx(custom_data.tree, pt);
if (candidate != size_t(-1)
&& custom_data.polys[candidate].contains(pt))
// Now ask the AABB tree which polygons we should check and check them.
std::vector<size_t> candidates;
AABBTreeIndirect::get_candidate_idxs(custom_data.tree, pt, candidates);
if (! candidates.empty())
for (size_t idx : candidates)
if (custom_data.polys[idx].contains(pt))
return true;
return false;
};