3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

New bridging logic, more robust. #58

Browse source
This commit is contained in:
Alessandro Ranellucci 2011-11-19 16:08:00 +01:00
parent 1ef4d006a0
commit a1c766cc52
8 changed files with 86 additions and 75 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/Slic3r/ExPolygon.pm
View file

@ -4,9 +4,8 @@ use warnings;
# an ExPolygon is a polygon with holes # an ExPolygon is a polygon with holes
use Math::Clipper qw(CT_UNION PFT_NONZERO JT_MITER);
use Slic3r::Geometry qw(point_in_polygon X Y A B); use Slic3r::Geometry qw(point_in_polygon X Y A B);
use Slic3r::Geometry::Clipper qw(union_ex); use Slic3r::Geometry::Clipper qw(union_ex JT_MITER);
# the constructor accepts an array of polygons # the constructor accepts an array of polygons
# or a Math::Clipper ExPolygon (hashref) # or a Math::Clipper ExPolygon (hashref)

2
lib/Slic3r/Fill.pm
View file

@ -58,8 +58,6 @@ sub make_fill {
])}; ])};
SURFACE: foreach my $surface (@$surfaces) { SURFACE: foreach my $surface (@$surfaces) {
Slic3r::debugf " Processing surface %s:\n", $surface->id;
my $filler = $Slic3r::fill_pattern; my $filler = $Slic3r::fill_pattern;
my $density = $Slic3r::fill_density; my $density = $Slic3r::fill_density;
my $flow_width = $Slic3r::flow_width; my $flow_width = $Slic3r::flow_width;

2
lib/Slic3r/Fill/Base.pm
View file

@ -24,7 +24,7 @@ sub infill_direction {
} }
# use bridge angle # use bridge angle
if ($surface->isa('Slic3r::Surface::Bridge')) { if ($surface->isa('Slic3r::Surface::Bridge') && defined $surface->bridge_angle) {
Slic3r::debugf "Filling bridge with angle %d\n", $surface->bridge_angle; Slic3r::debugf "Filling bridge with angle %d\n", $surface->bridge_angle;
$rotate[0] = Slic3r::Geometry::deg2rad($surface->bridge_angle); $rotate[0] = Slic3r::Geometry::deg2rad($surface->bridge_angle);
} }

113
lib/Slic3r/Layer.pm
View file

@ -356,83 +356,68 @@ sub process_bridges {
($_->surface_type eq 'bottom' && $self->id > 0) || $_->surface_type eq 'top' ($_->surface_type eq 'bottom' && $self->id > 0) || $_->surface_type eq 'top'
} @{$self->surfaces} or return; } @{$self->surfaces} or return;
my @supporting_surfaces = grep $_->surface_type =~ /internal/, @{$self->surfaces}; my @internal_surfaces = grep $_->surface_type =~ /internal/, @{$self->surfaces};
SURFACE: foreach my $surface (@solid_surfaces) { SURFACE: foreach my $surface (@solid_surfaces) {
# ignore holes in bridges; # ignore holes in bridges
# offset the surface a bit to avoid approximation issues when doing the
# intersection below (this is to make sure we overlap with supporting
# surfaces, otherwise a little gap will result from intersection)
my $contour = $surface->expolygon->contour->safety_offset; my $contour = $surface->expolygon->contour->safety_offset;
my $description = $surface->surface_type eq 'bottom' ? 'bridge/overhang' : 'reverse bridge'; my $description = $surface->surface_type eq 'bottom' ? 'bridge/overhang' : 'reverse bridge';
# offset the contour and intersect it with the internal surfaces to discover
# which of them has contact with our bridge
my @supporting_surfaces = ();
my ($contour_offset) = $contour->offset($Slic3r::flow_width / $Slic3r::resolution);
foreach my $internal_surface (@internal_surfaces) {
my $intersection = intersection_ex([$contour_offset], [$internal_surface->contour->p]);
if (@$intersection) {
push @supporting_surfaces, $internal_surface;
}
}
#use Slic3r::SVG; #use Slic3r::SVG;
#Slic3r::SVG::output(undef, "bridge.svg", #Slic3r::SVG::output(undef, "bridge.svg",
# green_polygons => [ map $_->p, @supporting_surfaces ], # green_polygons => [ map $_->p, @supporting_surfaces ],
# red_polygons => [ $contour ], # red_polygons => [ $contour ],
#); #);
# find all supported edges (as polylines, thus keeping notion of next SURFACE unless @supporting_surfaces;
# consecutive supported edges) Slic3r::debugf " Found $description on layer %d with %d support(s)\n",
my @supported_polylines = (); $self->id, scalar(@supporting_surfaces);
{
my @current_polyline = (); my $bridge_angle = undef;
EDGE: foreach my $edge ($contour->lines) { if ($surface->surface_type eq 'bottom') {
for my $supporting_surface (@supporting_surfaces) { # detect optimal bridge angle
local $Slic3r::Geometry::epsilon = 1E+7;
if (Slic3r::Geometry::polygon_has_subsegment($supporting_surface->contour->p, $edge)) { my $bridge_over_hole = 0;
push @current_polyline, $edge; my @edges = (); # edges are POLYLINES
next EDGE; foreach my $supporting_surface (@supporting_surfaces) {
my @surface_edges = $supporting_surface->contour->clip_with_polygon($contour_offset);
if (@surface_edges == 1 && @{$supporting_surface->contour->p} == @{$surface_edges[0]->p}) {
$bridge_over_hole = 1;
} else {
foreach my $edge (@surface_edges) {
shift @{$edge->points};
pop @{$edge->points};
} }
} }
if (@current_polyline) { push @edges, @surface_edges;
push @supported_polylines, [@current_polyline]; }
@current_polyline = (); Slic3r::debugf " Bridge is supported on %d edge(s)\n", scalar(@edges);
} Slic3r::debugf " and covers a hole\n" if $bridge_over_hole;
if (0) {
require "Slic3r/SVG.pm";
Slic3r::SVG::output(undef, "bridge.svg",
polylines => [ map $_->p, @edges ],
);
}
if (@edges == 2) {
my @chords = map Slic3r::Line->new($_->points->[0], $_->points->[-1]), @edges;
my @midpoints = map $_->midpoint, @chords;
$bridge_angle = -Slic3r::Geometry::rad2deg(Slic3r::Geometry::line_atan(\@midpoints) + PI/2);
Slic3r::debugf "Optimal infill angle of bridge on layer %d is %d degrees\n", $self->id, $bridge_angle;
} }
push @supported_polylines, [@current_polyline] if @current_polyline;
}
# defensive programming, this shouldn't happen
if (@supported_polylines == 0) {
Slic3r::debugf "Found $description with no supports on layer %d; ignoring\n", $self->id;
next SURFACE;
}
if (@supported_polylines == 1) {
Slic3r::debugf "Found $description with only one support on layer %d; ignoring\n", $self->id;
next SURFACE;
}
# now connect the first point to the last of each polyline
@supported_polylines = map [ $_->[0]->[0], $_->[-1]->[-1] ], @supported_polylines;
# @supported_polylines becomes actually an array of lines
# if we got more than two supports, get the longest two
if (@supported_polylines > 2) {
my %lengths = map { $_ => Slic3r::Geometry::line_length($_) } @supported_polylines;
@supported_polylines = sort { $lengths{"$a"} <=> $lengths{"$b"} } @supported_polylines;
@supported_polylines = @supported_polylines[-2,-1];
}
# connect the midpoints, that will give the the optimal infill direction
my @midpoints = map Slic3r::Geometry::midpoint($_), @supported_polylines;
my $bridge_angle = -Slic3r::Geometry::rad2deg(Slic3r::Geometry::line_atan(\@midpoints) + PI/2);
Slic3r::debugf "Optimal infill angle of bridge on layer %d is %d degrees\n", $self->id, $bridge_angle;
# detect which neighbor surfaces are now supporting our bridge
my @supporting_neighbor_surfaces = ();
foreach my $supporting_surface (@supporting_surfaces) {
local $Slic3r::Geometry::epsilon = 1E+7;
push @supporting_neighbor_surfaces, $supporting_surface
if grep Slic3r::Geometry::polygon_has_vertex($supporting_surface->contour->p, $_),
map $_->[0], @supported_polylines;
}
# defensive programming, this shouldn't happen
if (@supporting_neighbor_surfaces == 0) {
Slic3r::debugf "Couldn't find supporting surfaces on layer %d; ignoring\n", $self->id;
next SURFACE;
} }
# now, extend our bridge by taking a portion of supporting surfaces # now, extend our bridge by taking a portion of supporting surfaces
@ -443,7 +428,7 @@ sub process_bridges {
# calculate the new bridge # calculate the new bridge
my $intersection = intersection_ex( my $intersection = intersection_ex(
[ $contour, map $_->p, @supporting_neighbor_surfaces ], [ $contour, map $_->p, @supporting_surfaces ],
[ $bridge_offset ], [ $bridge_offset ],
); );
push @{$self->bridges}, map Slic3r::Surface::Bridge->cast_from_expolygon($_, push @{$self->bridges}, map Slic3r::Surface::Bridge->cast_from_expolygon($_,

2
lib/Slic3r/Perimeter.pm
View file

@ -8,7 +8,7 @@ use XXX;
sub make_perimeter { sub make_perimeter {
my $self = shift; my $self = shift;
my ($layer) = @_; my ($layer) = @_;
printf "Making perimeter for layer %d:\n", $layer->id; printf "Making perimeter for layer %d\n", $layer->id;
# at least one perimeter is required # at least one perimeter is required
die "Can't slice object with no perimeters!\n" die "Can't slice object with no perimeters!\n"

12
lib/Slic3r/Polygon.pm
View file

@ -9,6 +9,7 @@ use warnings;
use Slic3r::Geometry qw(polygon_lines polygon_remove_parallel_continuous_edges use Slic3r::Geometry qw(polygon_lines polygon_remove_parallel_continuous_edges
polygon_segment_having_point point_in_polygon move_points rotate_points); polygon_segment_having_point point_in_polygon move_points rotate_points);
use Slic3r::Geometry::Clipper qw(JT_MITER);
# the constructor accepts an array(ref) of points # the constructor accepts an array(ref) of points
sub new { sub new {
@ -75,4 +76,15 @@ sub safety_offset {
return (ref $self)->new(Slic3r::Geometry::Clipper::safety_offset([$self])->[0]); return (ref $self)->new(Slic3r::Geometry::Clipper::safety_offset([$self])->[0]);
} }
sub offset {
my $self = shift;
my ($distance, $scale, $joinType, $miterLimit) = @_;
$scale ||= $Slic3r::resolution * 1000000;
$joinType = JT_MITER if !defined $joinType;
$miterLimit ||= 2;
my $offsets = Math::Clipper::offset([$self], $distance, $scale, $joinType, $miterLimit);
return @$offsets;
}
1; 1;

5
lib/Slic3r/Polyline.pm
View file

@ -156,6 +156,11 @@ sub clip_with_expolygon {
push @polylines, $current_polyline; push @polylines, $current_polyline;
} }
if (@polylines > 1 && scalar(@{$polylines[-1]}) == 2 && $polylines[-1][-1] eq $polylines[0][0]) {
unshift @{$polylines[0]}, $polylines[-1][0];
pop @polylines;
}
return map Slic3r::Polyline->cast($_), @polylines; return map Slic3r::Polyline->cast($_), @polylines;
} }

22
lib/Slic3r/Print.pm
View file

@ -109,6 +109,23 @@ sub detect_surfaces_type {
my $upper_surfaces = [ grep { $_->expolygon->contour->area > $min_area } @{$upper_layer->surfaces} ]; my $upper_surfaces = [ grep { $_->expolygon->contour->area > $min_area } @{$upper_layer->surfaces} ];
@top = $surface_difference->($layer->surfaces, $upper_surfaces, 'top'); @top = $surface_difference->($layer->surfaces, $upper_surfaces, 'top');
# now check whether each resulting top surfaces is large enough to have its
# own perimeters or whether it may be sufficient to use the lower layer's
# perimeters
# offset upper layer's surfaces
my $upper_surfaces_offsetted;
{
my $distance = $Slic3r::flow_width * ($Slic3r::perimeters) / $Slic3r::resolution;
$upper_surfaces_offsetted = offset([ map $_->p, @{$upper_layer->surfaces} ], $distance, 100, JT_MITER, 2);
}
@top = grep {
my $surface = $_;
my $diff = diff_ex([ map $_->p, $surface ], $upper_surfaces_offsetted);
@$diff;
} @top;
} else { } else {
# if no upper layer, all surfaces of this one are solid # if no upper layer, all surfaces of this one are solid
@top = @{$layer->surfaces}; @top = @{$layer->surfaces};
@ -276,8 +293,6 @@ sub extrude_perimeters {
foreach my $layer (@{ $self->layers }) { foreach my $layer (@{ $self->layers }) {
$layer->detect_perimeter_surfaces; $layer->detect_perimeter_surfaces;
$perimeter_extruder->make_perimeter($layer); $perimeter_extruder->make_perimeter($layer);
Slic3r::debugf " generated paths: %s\n",
join ' ', map $_->id, @{ $layer->perimeters } if $Slic3r::debug;
} }
} }
@ -374,9 +389,6 @@ sub extrude_fills {
foreach my $layer (@{ $self->layers }) { foreach my $layer (@{ $self->layers }) {
$fill_extruder->make_fill($layer); $fill_extruder->make_fill($layer);
Slic3r::debugf " generated %d paths: %s\n",
scalar @{ $layer->fills },
join ' ', map $_->id, map @{$_->paths}, @{ $layer->fills } if $Slic3r::debug;
} }
} }