3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix format-security violations (#802)

Browse Source 
croak() expects printf-style format strings. Calling croak(e.what()) directly
causes compilations to fail with -Werror=format-security
This commit is contained in:
Chow Loong Jin 2018-03-21 15:38:33 +08:00 committed by bubnikv
parent 86b79f89ad
commit a32281c268
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xs/xsp/GCode.xsp
View File

@ -23,7 +23,7 @@
try { try {
THIS->do_export(print, path); THIS->do_export(print, path);
} catch (std::exception& e) { } catch (std::exception& e) {
croak(e.what()); croak("%s\n", e.what());
} }
%}; %};
void do_export_w_preview(Print *print, const char *path, GCodePreviewData *preview_data) void do_export_w_preview(Print *print, const char *path, GCodePreviewData *preview_data)

4
xs/xsp/PlaceholderParser.xsp
View File

@ -18,7 +18,7 @@
try { try {
RETVAL = THIS->process(str, 0); RETVAL = THIS->process(str, 0);
} catch (std::exception& e) { } catch (std::exception& e) {
croak(e.what()); croak("%s\n", e.what());
} }
%}; %};
@ -27,7 +27,7 @@
try { try {
RETVAL = THIS->evaluate_boolean_expression(str, THIS->config()); RETVAL = THIS->evaluate_boolean_expression(str, THIS->config());
} catch (std::exception& e) { } catch (std::exception& e) {
croak(e.what()); croak("%s\n", e.what());
} }
%}; %};
}; };

2
xs/xsp/Print.xsp
View File

@ -212,7 +212,7 @@ _constant()
try { try {
RETVAL = THIS->output_filepath(path); RETVAL = THIS->output_filepath(path);
} catch (std::exception& e) { } catch (std::exception& e) {
croak(e.what()); croak("%s\n", e.what());
} }
%}; %};