Fixed context menu showing up when user right clicks on 3D scene and release the mouse button after dragging over the objects list
This commit is contained in:
parent
1ade11fd57
commit
a6a7303e25
@ -2662,19 +2662,6 @@ std::string format_mouse_event_debug_message(const wxMouseEvent &evt)
|
|||||||
|
|
||||||
void GLCanvas3D::on_mouse(wxMouseEvent& evt)
|
void GLCanvas3D::on_mouse(wxMouseEvent& evt)
|
||||||
{
|
{
|
||||||
auto mouse_up_cleanup = [this](){
|
|
||||||
m_moving = false;
|
|
||||||
m_mouse.drag.move_volume_idx = -1;
|
|
||||||
m_mouse.set_start_position_3D_as_invalid();
|
|
||||||
m_mouse.set_start_position_2D_as_invalid();
|
|
||||||
m_mouse.dragging = false;
|
|
||||||
m_mouse.ignore_left_up = false;
|
|
||||||
m_dirty = true;
|
|
||||||
|
|
||||||
if (m_canvas->HasCapture())
|
|
||||||
m_canvas->ReleaseMouse();
|
|
||||||
};
|
|
||||||
|
|
||||||
#if ENABLE_RETINA_GL
|
#if ENABLE_RETINA_GL
|
||||||
const float scale = m_retina_helper->get_scale_factor();
|
const float scale = m_retina_helper->get_scale_factor();
|
||||||
evt.SetX(evt.GetX() * scale);
|
evt.SetX(evt.GetX() * scale);
|
||||||
@ -3511,6 +3498,20 @@ void GLCanvas3D::export_toolpaths_to_obj(const char* filename) const
|
|||||||
m_volumes.export_toolpaths_to_obj(filename);
|
m_volumes.export_toolpaths_to_obj(filename);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
void GLCanvas3D::mouse_up_cleanup()
|
||||||
|
{
|
||||||
|
m_moving = false;
|
||||||
|
m_mouse.drag.move_volume_idx = -1;
|
||||||
|
m_mouse.set_start_position_3D_as_invalid();
|
||||||
|
m_mouse.set_start_position_2D_as_invalid();
|
||||||
|
m_mouse.dragging = false;
|
||||||
|
m_mouse.ignore_left_up = false;
|
||||||
|
m_dirty = true;
|
||||||
|
|
||||||
|
if (m_canvas->HasCapture())
|
||||||
|
m_canvas->ReleaseMouse();
|
||||||
|
}
|
||||||
|
|
||||||
bool GLCanvas3D::_is_shown_on_screen() const
|
bool GLCanvas3D::_is_shown_on_screen() const
|
||||||
{
|
{
|
||||||
return (m_canvas != nullptr) ? m_canvas->IsShownOnScreen() : false;
|
return (m_canvas != nullptr) ? m_canvas->IsShownOnScreen() : false;
|
||||||
|
@ -624,6 +624,8 @@ public:
|
|||||||
bool has_toolpaths_to_export() const;
|
bool has_toolpaths_to_export() const;
|
||||||
void export_toolpaths_to_obj(const char* filename) const;
|
void export_toolpaths_to_obj(const char* filename) const;
|
||||||
|
|
||||||
|
void mouse_up_cleanup();
|
||||||
|
|
||||||
private:
|
private:
|
||||||
bool _is_shown_on_screen() const;
|
bool _is_shown_on_screen() const;
|
||||||
|
|
||||||
|
@ -778,7 +778,13 @@ void ObjectList::OnChar(wxKeyEvent& event)
|
|||||||
|
|
||||||
void ObjectList::OnContextMenu(wxDataViewEvent&)
|
void ObjectList::OnContextMenu(wxDataViewEvent&)
|
||||||
{
|
{
|
||||||
list_manipulation(true);
|
// Do not show the context menu if the user pressed the right mouse button on the 3D scene and released it on the objects list
|
||||||
|
GLCanvas3D* canvas = wxGetApp().plater()->canvas3D();
|
||||||
|
bool evt_context_menu = (canvas != nullptr) ? !canvas->is_mouse_dragging() : true;
|
||||||
|
if (!evt_context_menu)
|
||||||
|
canvas->mouse_up_cleanup();
|
||||||
|
|
||||||
|
list_manipulation(evt_context_menu);
|
||||||
}
|
}
|
||||||
|
|
||||||
void ObjectList::list_manipulation(bool evt_context_menu/* = false*/)
|
void ObjectList::list_manipulation(bool evt_context_menu/* = false*/)
|
||||||
|
Loading…
Reference in New Issue
Block a user