3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

RemovableDriveManager: not calling update from status()

Browse source 
Update was called too often on main thread mostly from status() causing delays
This commit is contained in:
David Kocik 2020-03-12 11:54:27 +01:00
parent c145d60df4
commit b941560736
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/slic3r/GUI/RemovableDriveManager.cpp
View file

@ -469,9 +469,6 @@ bool RemovableDriveManager::set_and_verify_last_save_path(const std::string &pat
RemovableDriveManager::RemovableDrivesStatus RemovableDriveManager::status() RemovableDriveManager::RemovableDrivesStatus RemovableDriveManager::status()
{ {
#ifndef REMOVABLE_DRIVE_MANAGER_OS_CALLBACKS
this->update();
#endif // REMOVABLE_DRIVE_MANAGER_OS_CALLBACKS
RemovableDriveManager::RemovableDrivesStatus out; RemovableDriveManager::RemovableDrivesStatus out;
{ {

2
src/slic3r/GUI/RemovableDriveManager.hpp
View file

@ -69,6 +69,8 @@ public:
// On Windows, the function does not block, and the eject is detected in the background thread. // On Windows, the function does not block, and the eject is detected in the background thread.
void eject_drive(); void eject_drive();
// Status is used to retrieve info for showing UI buttons.
// Status is called every time when change of UI buttons is possible therefore should not perform update.
struct RemovableDrivesStatus { struct RemovableDrivesStatus {
bool has_removable_drives { false }; bool has_removable_drives { false };
bool has_eject { false }; bool has_eject { false };