3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Return objects by reference instead of always cloning

Browse source
This commit is contained in:
Alessandro Ranellucci 2013-09-02 20:22:20 +02:00
parent 1741301973
commit c0789506e4
30 changed files with 158 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/Slic3r/Fill.pm
View file

@ -180,9 +180,10 @@ sub make_fill {
# save into layer
push @fills, my $collection = Slic3r::ExtrusionPath::Collection->new;
$collection->no_sort($params->{no_sort});
$collection->append(
map Slic3r::ExtrusionPath->new(
polyline => Slic3r::Polyline->new(@$_),
polyline => $_,
role => ($surface->surface_type == S_TYPE_INTERNALBRIDGE
? EXTR_ROLE_INTERNALBRIDGE
: $is_bridge

4
lib/Slic3r/Fill/Honeycomb.pm
View file

@ -108,7 +108,9 @@ sub fill_surface {
next;
}
}
push @paths, $path;
# make a clone before $collection goes out of scope
push @paths, $path->clone;
}
}

4
lib/Slic3r/Fill/Rectilinear.pm
View file

@ -91,7 +91,9 @@ sub fill_surface {
next;
}
}
push @polylines, $polyline;
# make a clone before $collection goes out of scope
push @polylines, $polyline->clone;
}
}

8
lib/Slic3r/Layer/Region.pm
View file

@ -252,7 +252,7 @@ sub make_perimeters {
# use a nearest neighbor search to order these children
# TODO: supply second argument to chained_path_items() too?
my @nodes = @{Slic3r::Geometry::chained_path_items(
[ map [ Slic3r::Point->new(@{$_->{outer} ? $_->{outer}[0] : $_->{hole}[0]}), $_ ], @$polynodes ],
[ map [ ($_->{outer} // $_->{hole})->first_point->clone, $_ ], @$polynodes ],
)};
my @loops = ();
@ -262,7 +262,9 @@ sub make_perimeters {
# return ccw contours and cw holes
# GCode.pm will convert all of them to ccw, but it needs to know
# what the holes are in order to compute the correct inwards move
my $polygon = Slic3r::Polygon->new(defined $polynode->{outer} ? @{$polynode->{outer}} : reverse @{$polynode->{hole}});
my $polygon = ($polynode->{outer} // $polynode->{hole})->clone;
$polygon->reverse if defined $polynode->{hole};
$polygon->reverse if !$is_contour;
my $role = EXTR_ROLE_PERIMETER;
@ -302,7 +304,7 @@ sub make_perimeters {
# add thin walls as perimeters
push @{ $self->perimeters }, @{Slic3r::ExtrusionPath::Collection->new(
map Slic3r::ExtrusionPath->new(
polyline => ($_->isa('Slic3r::Polygon') ? $_->split_at_first_point : $_),
polyline => ($_->isa('Slic3r::Polygon') ? $_->split_at_first_point : $_->clone),
role => EXTR_ROLE_EXTERNAL_PERIMETER,
flow_spacing => $self->perimeter_flow->spacing,
), @{ $self->thin_walls }