From c793a2657f0f900dd8fd06b13dd61ead7f3178fa Mon Sep 17 00:00:00 2001 From: Alessandro Ranellucci Date: Mon, 22 Oct 2012 15:29:54 +0200 Subject: [PATCH] Replace Math::ConvexHull with Math::ConvexHull::MonotoneChain. #722 --- Build.PL | 2 +- lib/Slic3r/GUI/Plater.pm | 7 +++---- lib/Slic3r/Print.pm | 6 ++---- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/Build.PL b/Build.PL index 513a26955..4ad56e18e 100644 --- a/Build.PL +++ b/Build.PL @@ -12,7 +12,7 @@ my $build = Module::Build->new( 'File::Spec' => '0', 'Getopt::Long' => '0', 'Math::Clipper' => '1.09', - 'Math::ConvexHull' => '1.0.4', + 'Math::ConvexHull::MonotoneChain' => '0.01', 'Math::Geometry::Voronoi' => '1.3', 'Math::PlanePath' => '53', 'Moo' => '0.091009', diff --git a/lib/Slic3r/GUI/Plater.pm b/lib/Slic3r/GUI/Plater.pm index b5196ec1e..6d1f093c3 100644 --- a/lib/Slic3r/GUI/Plater.pm +++ b/lib/Slic3r/GUI/Plater.pm @@ -5,7 +5,7 @@ use utf8; use File::Basename qw(basename dirname); use List::Util qw(max sum); -use Math::ConvexHull qw(convex_hull); +use Math::ConvexHull::MonotoneChain qw(convex_hull); use Slic3r::Geometry qw(X Y Z X1 Y1 X2 Y2 MIN MAX); use Slic3r::Geometry::Clipper qw(JT_ROUND); use threads::shared qw(shared_clone); @@ -1012,8 +1012,8 @@ sub OnDropFiles { package Slic3r::GUI::Plater::Object; use Moo; -use Math::ConvexHull qw(convex_hull); -use Slic3r::Geometry qw(X Y remove_coinciding_points); +use Math::ConvexHull::MonotoneChain qw(convex_hull); +use Slic3r::Geometry qw(X Y); has 'name' => (is => 'rw', required => 1); has 'input_file' => (is => 'rw', required => 1); @@ -1056,7 +1056,6 @@ sub make_thumbnail { my %params = @_; my @points = map [ @$_[X,Y] ], @{$self->model_object->mesh->vertices}; - remove_coinciding_points(\@points); my $convex_hull = Slic3r::Polygon->new(convex_hull(\@points)); for (@$convex_hull) { @$_ = map $_ * $params{scaling_factor}, @$_; diff --git a/lib/Slic3r/Print.pm b/lib/Slic3r/Print.pm index c82bd30d7..3669187b2 100644 --- a/lib/Slic3r/Print.pm +++ b/lib/Slic3r/Print.pm @@ -4,9 +4,9 @@ use Moo; use File::Basename qw(basename fileparse); use File::Spec; use List::Util qw(max); -use Math::ConvexHull 1.0.4 qw(convex_hull); +use Math::ConvexHull::MonotoneChain qw(convex_hull); use Slic3r::ExtrusionPath ':roles'; -use Slic3r::Geometry qw(X Y Z X1 Y1 X2 Y2 MIN PI scale unscale move_points nearest_point remove_coinciding_points); +use Slic3r::Geometry qw(X Y Z X1 Y1 X2 Y2 MIN PI scale unscale move_points nearest_point); use Slic3r::Geometry::Clipper qw(diff_ex union_ex intersection_ex offset JT_ROUND JT_SQUARE); use Time::HiRes qw(gettimeofday tv_interval); @@ -139,7 +139,6 @@ sub validate { my $clearance; { my @points = map [ @$_[X,Y] ], map @{$_->vertices}, @{$self->objects->[$obj_idx]->meshes}; - remove_coinciding_points(\@points); my $convex_hull = Slic3r::Polygon->new(convex_hull(\@points)); $clearance = +($convex_hull->offset(scale $Slic3r::Config->extruder_clearance_radius / 2, 1, JT_ROUND))[0]; } @@ -565,7 +564,6 @@ sub make_skirt { return if @points < 3; # at least three points required for a convex hull # find out convex hull - remove_coinciding_points(\@points); my $convex_hull = convex_hull(\@points); # draw outlines from outside to inside