diff --git a/src/slic3r/GUI/ConfigWizard.cpp b/src/slic3r/GUI/ConfigWizard.cpp
index 7da420e76..5da320830 100644
--- a/src/slic3r/GUI/ConfigWizard.cpp
+++ b/src/slic3r/GUI/ConfigWizard.cpp
@@ -635,6 +635,7 @@ void PageTemperatures::apply_custom_config(DynamicPrintConfig &config)
ConfigWizardIndex::ConfigWizardIndex(wxWindow *parent)
: wxPanel(parent)
+ // XXX: use create_scaled_bitmap:
, bg(GUI::from_u8(Slic3r::var("Slic3r_192px_transparent.png")), wxBITMAP_TYPE_PNG)
, bullet_black(GUI::from_u8(Slic3r::var("bullet_black.png")), wxBITMAP_TYPE_PNG)
, bullet_blue(GUI::from_u8(Slic3r::var("bullet_blue.png")), wxBITMAP_TYPE_PNG)
@@ -769,6 +770,8 @@ void ConfigWizardIndex::on_paint(wxPaintEvent & evt)
const int yoff_text = bullet_h > em_h ? (bullet_h - em_h) / 2 : 0;
const int yinc = item_height();
+ int index_width = 0;
+
unsigned y = 0;
for (size_t i = 0; i < items.size(); i++) {
const Item& item = items[i];
@@ -780,8 +783,18 @@ void ConfigWizardIndex::on_paint(wxPaintEvent & evt)
else if (i < item_active) { dc.DrawBitmap(bullet_black, x, y + yoff_icon, false); }
else if (i > item_active) { dc.DrawBitmap(bullet_white, x, y + yoff_icon, false); }
- dc.DrawText(item.label, x + bullet_w + em/2, y + yoff_text);
+ x += + bullet_w + em/2;
+ const auto text_size = dc.GetTextExtent(item.label);
+ dc.DrawText(item.label, x, y + yoff_text);
+
y += yinc;
+ index_width = std::max(index_width, (int)x + text_size.x);
+ }
+
+ if (GetMinSize().x < index_width) {
+ CallAfter([this, index_width]() {
+ SetMinSize(wxSize(index_width, GetMinSize().y));
+ });
}
}
diff --git a/src/slic3r/GUI/Field.cpp b/src/slic3r/GUI/Field.cpp
index d77405230..6da0800d9 100644
--- a/src/slic3r/GUI/Field.cpp
+++ b/src/slic3r/GUI/Field.cpp
@@ -45,8 +45,7 @@ void Field::PostInitialize()
m_Undo_to_sys_btn->Bind(wxEVT_BUTTON, ([this](wxCommandEvent) { on_back_to_sys_value(); }));
//set default bitmap
- wxBitmap bmp;
- bmp.LoadFile(from_u8(var("bullet_white.png")), wxBITMAP_TYPE_PNG);
+ wxBitmap bmp = create_scaled_bitmap(m_parent, "bullet_white.png");
set_undo_bitmap(&bmp);
set_undo_to_sys_bitmap(&bmp);
diff --git a/src/slic3r/GUI/GUI_App.cpp b/src/slic3r/GUI/GUI_App.cpp
index b529b2916..62b8581be 100644
--- a/src/slic3r/GUI/GUI_App.cpp
+++ b/src/slic3r/GUI/GUI_App.cpp
@@ -34,7 +34,7 @@
#include "../Utils/PresetUpdater.hpp"
#include "../Utils/PrintHost.hpp"
-#include "ConfigWizard_private.hpp"
+#include "ConfigWizard.hpp"
#include "slic3r/Config/Snapshot.hpp"
#include "ConfigSnapshotDialog.hpp"
#include "FirmwareDialog.hpp"
@@ -230,7 +230,7 @@ bool GUI_App::on_init_inner()
// and after MainFrame is created & shown.
// The extra CallAfter() is needed because of Mac, where this is the only way
// to popup a modal dialog on start without screwing combo boxes.
- // This is ugly but I honestly found not better way to do it.
+ // This is ugly but I honestly found no better way to do it.
// Neither wxShowEvent nor wxWindowCreateEvent work reliably.
static bool once = true;
if (once) {
diff --git a/src/slic3r/GUI/Plater.cpp b/src/slic3r/GUI/Plater.cpp
index 5dc1697e1..8eb68fc39 100644
--- a/src/slic3r/GUI/Plater.cpp
+++ b/src/slic3r/GUI/Plater.cpp
@@ -1169,8 +1169,8 @@ struct Plater::priv
wxString project_filename;
BackgroundSlicingProcess background_process;
- std::atomic<bool> arranging;
- std::atomic<bool> rotoptimizing;
+ bool arranging;
+ bool rotoptimizing;
bool delayed_scene_refresh;
std::string delayed_error_message;
@@ -1333,8 +1333,8 @@ Plater::priv::priv(Plater *q, MainFrame *main_frame)
, view_toolbar(GLToolbar::Radio)
#endif // ENABLE_SVG_ICONS
{
- arranging.store(false);
- rotoptimizing.store(false);
+ arranging = false;
+ rotoptimizing = false;
background_process.set_fff_print(&fff_print);
background_process.set_sla_print(&sla_print);
background_process.set_gcode_preview_data(&gcode_preview_data);
@@ -2025,15 +2025,14 @@ void Plater::priv::mirror(Axis axis)
void Plater::priv::arrange()
{
- // don't do anything if currently arranging. Then this is a re-entrance
- if(arranging.load()) return;
-
- // Guard the arrange process
- arranging.store(true);
+ if (arranging) { return; }
+ arranging = true;
+ Slic3r::ScopeGuard arranging_guard([this]() { arranging = false; });
wxBusyCursor wait;
this->background_process.stop();
+
unsigned count = 0;
for(auto obj : model.objects) count += obj->instances.size();
@@ -2049,14 +2048,14 @@ void Plater::priv::arrange()
statusbar()->set_progress(count - st);
statusbar()->set_status_text(msg);
- // ok, this is dangerous, but we are protected by the atomic flag
+ // ok, this is dangerous, but we are protected by the flag
// 'arranging' and the arrange button is also disabled.
// This call is needed for the cancel button to work.
wxYieldIfNeeded();
};
statusbar()->set_cancel_callback([this, statusfn](){
- arranging.store(false);
+ arranging = false;
statusfn(0, L("Arranging canceled"));
});
@@ -2092,7 +2091,7 @@ void Plater::priv::arrange()
hint,
false, // create many piles not just one pile
[statusfn](unsigned st) { statusfn(st, arrangestr); },
- [this] () { return !arranging.load(); });
+ [this] () { return !arranging; });
} catch(std::exception& /*e*/) {
GUI::show_error(this->q, L("Could not arrange model objects! "
"Some geometries may be invalid."));
@@ -2101,7 +2100,6 @@ void Plater::priv::arrange()
statusfn(0, L("Arranging done."));
statusbar()->set_range(prev_range);
statusbar()->set_cancel_callback(); // remove cancel button
- arranging.store(false);
// Do a full refresh of scene tree, including regenerating all the GLVolumes.
//FIXME The update function shall just reload the modified matrices.
@@ -2116,11 +2114,12 @@ void Plater::priv::sla_optimize_rotation() {
// running we should probably disable explicit slicing and background
// processing
- if(rotoptimizing.load()) return;
- rotoptimizing.store(true);
+ if (rotoptimizing) { return; }
+ rotoptimizing = true;
+ Slic3r::ScopeGuard rotoptimizing_guard([this]() { rotoptimizing = false; });
int obj_idx = get_selected_object_idx();
- if(obj_idx < 0) { rotoptimizing.store(false); return; }
+ if (obj_idx < 0) { return; }
ModelObject * o = model.objects[size_t(obj_idx)];
@@ -2138,14 +2137,14 @@ void Plater::priv::sla_optimize_rotation() {
};
statusbar()->set_cancel_callback([this, stfn](){
- rotoptimizing.store(false);
+ rotoptimizing = false;
stfn(0, L("Orientation search canceled"));
});
auto r = sla::find_best_rotation(
*o, .005f,
[stfn](unsigned s) { stfn(s, L("Searching for optimal orientation")); },
- [this](){ return !rotoptimizing.load(); }
+ [this](){ return !rotoptimizing; }
);
const auto *bed_shape_opt = config->opt<ConfigOptionPoints>("bed_shape");
@@ -2158,7 +2157,7 @@ void Plater::priv::sla_optimize_rotation() {
double mindist = 6.0; // FIXME
double offs = mindist / 2.0 - EPSILON;
- if(rotoptimizing.load()) // wasn't canceled
+ if(rotoptimizing) // wasn't canceled
for(ModelInstance * oi : o->instances) {
oi->set_rotation({r[X], r[Y], r[Z]});
@@ -2208,7 +2207,6 @@ void Plater::priv::sla_optimize_rotation() {
stfn(0, L("Orientation found."));
statusbar()->set_range(prev_range);
statusbar()->set_cancel_callback();
- rotoptimizing.store(false);
update(true);
}
@@ -2386,6 +2384,11 @@ unsigned int Plater::priv::update_background_process(bool force_validation)
// Restart background processing thread based on a bitmask of UpdateBackgroundProcessReturnState.
bool Plater::priv::restart_background_process(unsigned int state)
{
+ if (arranging || rotoptimizing) {
+ // Avoid a race condition
+ return false;
+ }
+
if ( ! this->background_process.empty() &&
(state & priv::UPDATE_BACKGROUND_PROCESS_INVALID) == 0 &&
( ((state & UPDATE_BACKGROUND_PROCESS_FORCE_RESTART) != 0 && ! this->background_process.finished()) ||
@@ -2612,6 +2615,11 @@ void Plater::priv::on_select_preset(wxCommandEvent &evt)
void Plater::priv::on_slicing_update(SlicingStatusEvent &evt)
{
if (evt.status.percent >= -1) {
+ if (arranging || rotoptimizing) {
+ // Avoid a race condition
+ return;
+ }
+
this->statusbar()->set_progress(evt.status.percent);
this->statusbar()->set_status_text(_(L(evt.status.text)) + wxString::FromUTF8("…"));
}
@@ -3069,12 +3077,20 @@ bool Plater::priv::can_delete_all() const
bool Plater::priv::can_increase_instances() const
{
+ if (arranging || rotoptimizing) {
+ return false;
+ }
+
int obj_idx = get_selected_object_idx();
return (0 <= obj_idx) && (obj_idx < (int)model.objects.size());
}
bool Plater::priv::can_decrease_instances() const
{
+ if (arranging || rotoptimizing) {
+ return false;
+ }
+
int obj_idx = get_selected_object_idx();
return (0 <= obj_idx) && (obj_idx < (int)model.objects.size()) && (model.objects[obj_idx]->instances.size() > 1);
}
@@ -3091,7 +3107,7 @@ bool Plater::priv::can_split_to_volumes() const
bool Plater::priv::can_arrange() const
{
- return !model.objects.empty() && !arranging.load();
+ return !model.objects.empty() && !arranging;
}
bool Plater::priv::can_layers_editing() const
@@ -3232,9 +3248,9 @@ void Plater::remove_selected()
void Plater::increase_instances(size_t num)
{
+ if (! can_increase_instances()) { return; }
+
int obj_idx = p->get_selected_object_idx();
- if (obj_idx == -1)
- return;
ModelObject* model_object = p->model.objects[obj_idx];
ModelInstance* model_instance = model_object->instances.back();
@@ -3266,9 +3282,9 @@ void Plater::increase_instances(size_t num)
void Plater::decrease_instances(size_t num)
{
+ if (! can_decrease_instances()) { return; }
+
int obj_idx = p->get_selected_object_idx();
- if (obj_idx == -1)
- return;
ModelObject* model_object = p->model.objects[obj_idx];
if (model_object->instances.size() > num) {