3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Bugfix: crash on Windows when deleting the first object part. #2774

Browse source
This commit is contained in:
Alessandro Ranellucci 2015-05-05 01:11:41 +02:00
parent 63af442e3e
commit d998d97754
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/Slic3r/GUI/Plater/ObjectPartsPanel.pm
View file

@ -99,6 +99,7 @@ sub new {
}); });
EVT_TREE_SEL_CHANGED($self, $tree, sub { EVT_TREE_SEL_CHANGED($self, $tree, sub {
my ($self, $event) = @_; my ($self, $event) = @_;
return if $self->{disable_tree_sel_changed_event};
$self->selection_changed; $self->selection_changed;
}); });
EVT_BUTTON($self, $self->{btn_load_part}, sub { $self->on_btn_load(0) }); EVT_BUTTON($self, $self->{btn_load_part}, sub { $self->on_btn_load(0) });
@ -118,7 +119,14 @@ sub reload_tree {
my $tree = $self->{tree}; my $tree = $self->{tree};
my $rootId = $tree->GetRootItem; my $rootId = $tree->GetRootItem;
# despite wxWidgets states that DeleteChildren "will not generate any events unlike Delete() method",
# the MSW implementation of DeleteChildren actually calls Delete() for each item, so
# EVT_TREE_SEL_CHANGED is being called, with bad effects (the event handler is called; this
# subroutine is never continued; an invisible EndModal is called on the dialog causing Plater
# to continue its logic and rescheduling the background process etc. GH #2774)
$self->{disable_tree_sel_changed_event} = 1;
$tree->DeleteChildren($rootId); $tree->DeleteChildren($rootId);
$self->{disable_tree_sel_changed_event} = 0;
my $selectedId = $rootId; my $selectedId = $rootId;
foreach my $volume_id (0..$#{$object->volumes}) { foreach my $volume_id (0..$#{$object->volumes}) {