3DPrinting/PrusaSlicer-NonPlainar
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bugfix: segfault in SurfaceCollection->group(), fixed with a better implementation. #1566

Browse Source
This commit is contained in:
Alessandro Ranellucci 2013-12-04 00:10:31 +01:00
parent 57fd6ad563
commit e9b87b69df
3 changed files with 21 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
xs/src/SurfaceCollection.cpp
View File

@ -21,34 +21,31 @@ SurfaceCollection::simplify(double tolerance)
/* group surfaces by common properties */ /* group surfaces by common properties */
void void
SurfaceCollection::group(std::vector<SurfacesPtr> &retval, bool merge_solid) SurfaceCollection::group(std::vector<SurfacesPtr> *retval, bool merge_solid)
{ {
typedef std::map<t_surface_group_key,SurfacesPtr> t_unique_map;
t_unique_map unique_map;
for (Surfaces::iterator it = this->surfaces.begin(); it != this->surfaces.end(); ++it) { for (Surfaces::iterator it = this->surfaces.begin(); it != this->surfaces.end(); ++it) {
// build the t_surface_group_key struct with this surface's properties // find a group with the same properties
t_surface_group_key key; SurfacesPtr* group = NULL;
if (merge_solid && it->is_solid()) { for (std::vector<SurfacesPtr>::iterator git = retval->begin(); git != retval->end(); ++git) {
key.surface_type = stTop; Surface* gkey = git->front();
} else { if ((gkey->surface_type == it->surface_type || (merge_solid && gkey->is_solid() && it->is_solid()))
key.surface_type = it->surface_type; && gkey->thickness == it->thickness
&& gkey->thickness_layers == it->thickness_layers
&& gkey->bridge_angle == it->bridge_angle) {
group = &*git;
break;
} }
key.thickness = it->thickness;
key.thickness_layers = it->thickness_layers;
key.bridge_angle = it->bridge_angle;
// check whether we already have a group for these properties
if (unique_map.find(key) == unique_map.end()) {
// no group exists, add it
unique_map[key] = SurfacesPtr();
}
unique_map[key].push_back(&*it);
} }
retval.reserve(unique_map.size()); // if no group with these properties exists, add one
for (t_unique_map::const_iterator it = unique_map.begin(); it != unique_map.end(); ++it) if (group == NULL) {
retval.push_back(it->second); retval->resize(retval->size() + 1);
group = &retval->back();
}
// append surface to group
group->push_back(&*it);
}
} }
} }

16
xs/src/SurfaceCollection.hpp
View File

@ -6,26 +6,12 @@
namespace Slic3r { namespace Slic3r {
struct t_surface_group_key {
SurfaceType surface_type;
double thickness;
unsigned short thickness_layers;
double bridge_angle;
bool operator< (const t_surface_group_key &key) const {
return (this->surface_type < key.surface_type)
|| (this->thickness < key.thickness)
|| (this->thickness_layers < key.thickness_layers)
|| (this->bridge_angle < key.bridge_angle);
}
};
class SurfaceCollection class SurfaceCollection
{ {
public: public:
Surfaces surfaces; Surfaces surfaces;
void simplify(double tolerance); void simplify(double tolerance);
void group(std::vector<SurfacesPtr> &retval, bool merge_solid = false); void group(std::vector<SurfacesPtr> *retval, bool merge_solid = false);
}; };
} }

2
xs/xsp/SurfaceCollection.xsp
View File

@ -80,7 +80,7 @@ SurfaceCollection::group(merge_solid = false)
CODE: CODE:
// perform grouping // perform grouping
std::vector<SurfacesPtr> groups; std::vector<SurfacesPtr> groups;
THIS->group(groups, merge_solid); THIS->group(&groups, merge_solid);
// build return arrayref // build return arrayref
AV* av = newAV(); AV* av = newAV();