From f8b1dc550685a8ca76c4d7a810151eabf08db2c1 Mon Sep 17 00:00:00 2001 From: Enrico Turri Date: Mon, 23 Apr 2018 08:44:24 +0200 Subject: [PATCH] Tweaks to zooming logic --- lib/Slic3r/GUI/3DScene.pm | 124 ++++++++++++++++++++++++----- lib/Slic3r/GUI/Plater.pm | 1 + lib/Slic3r/GUI/Plater/3DPreview.pm | 21 +---- 3 files changed, 105 insertions(+), 41 deletions(-) diff --git a/lib/Slic3r/GUI/3DScene.pm b/lib/Slic3r/GUI/3DScene.pm index 65abf850e..ff6d73399 100644 --- a/lib/Slic3r/GUI/3DScene.pm +++ b/lib/Slic3r/GUI/3DScene.pm @@ -201,6 +201,10 @@ sub new { $self->select_view('left'); } elsif ($key == ord('6')) { $self->select_view('right'); + } elsif ($key == ord('z')) { + $self->zoom_to_volumes; + } elsif ($key == ord('b')) { + $self->zoom_to_bed; } else { $event->Skip; } @@ -599,22 +603,23 @@ sub mouse_wheel_event { $zoom = $zoom_min if defined $zoom_min && $zoom < $zoom_min; $self->_zoom($zoom); - # In order to zoom around the mouse point we need to translate - # the camera target - my $size = Slic3r::Pointf->new($self->GetSizeWH); - my $pos = Slic3r::Pointf->new($e->GetX, $size->y - $e->GetY); #- - $self->_camera_target->translate( - # ($pos - $size/2) represents the vector from the viewport center - # to the mouse point. By multiplying it by $zoom we get the new, - # transformed, length of such vector. - # Since we want that point to stay fixed, we move our camera target - # in the opposite direction by the delta of the length of such vector - # ($zoom - 1). We then scale everything by 1/$self->_zoom since - # $self->_camera_target is expressed in terms of model units. - -($pos->x - $size->x/2) * ($zoom) / $self->_zoom, - -($pos->y - $size->y/2) * ($zoom) / $self->_zoom, - 0, - ) if 0; +# # In order to zoom around the mouse point we need to translate +# # the camera target +# my $size = Slic3r::Pointf->new($self->GetSizeWH); +# my $pos = Slic3r::Pointf->new($e->GetX, $size->y - $e->GetY); #- +# $self->_camera_target->translate( +# # ($pos - $size/2) represents the vector from the viewport center +# # to the mouse point. By multiplying it by $zoom we get the new, +# # transformed, length of such vector. +# # Since we want that point to stay fixed, we move our camera target +# # in the opposite direction by the delta of the length of such vector +# # ($zoom - 1). We then scale everything by 1/$self->_zoom since +# # $self->_camera_target is expressed in terms of model units. +# -($pos->x - $size->x/2) * ($zoom) / $self->_zoom, +# -($pos->y - $size->y/2) * ($zoom) / $self->_zoom, +# 0, +# ) if 0; + $self->on_viewport_changed->() if $self->on_viewport_changed; $self->Resize($self->GetSizeWH) if $self->IsShownOnScreen; $self->Refresh; @@ -683,9 +688,82 @@ sub select_view { sub get_zoom_to_bounding_box_factor { my ($self, $bb) = @_; - return undef if ($bb->empty); - my $max_size = max(@{$bb->size}) * 2; - return ($max_size == 0) ? undef : min($self->GetSizeWH) / $max_size; + my $max_bb_size = max(@{ $bb->size }); + return undef if ($max_bb_size == 0); + + # project the bbox vertices on a plane perpendicular to the camera forward axis + # then calculates the vertices coordinate on this plane along the camera xy axes + + # we need the view matrix, we let opengl calculate it (same as done in render sub) + glMatrixMode(GL_MODELVIEW); + glLoadIdentity(); + + if (!TURNTABLE_MODE) { + # Shift the perspective camera. + my $camera_pos = Slic3r::Pointf3->new(0,0,-$self->_camera_distance); + glTranslatef(@$camera_pos); + } + + if (TURNTABLE_MODE) { + # Turntable mode is enabled by default. + glRotatef(-$self->_stheta, 1, 0, 0); # pitch + glRotatef($self->_sphi, 0, 0, 1); # yaw + } else { + # Shift the perspective camera. + my $camera_pos = Slic3r::Pointf3->new(0,0,-$self->_camera_distance); + glTranslatef(@$camera_pos); + my @rotmat = quat_to_rotmatrix($self->quat); + glMultMatrixd_p(@rotmat[0..15]); + } + glTranslatef(@{ $self->_camera_target->negative }); + + # get the view matrix back from opengl + my @matrix = glGetFloatv_p(GL_MODELVIEW_MATRIX); + + # camera axes + my $right = Slic3r::Pointf3->new($matrix[0], $matrix[4], $matrix[8]); + my $up = Slic3r::Pointf3->new($matrix[1], $matrix[5], $matrix[9]); + my $forward = Slic3r::Pointf3->new($matrix[2], $matrix[6], $matrix[10]); + + my $bb_min = $bb->min_point(); + my $bb_max = $bb->max_point(); + my $bb_center = $bb->center(); + + # bbox vertices in world space + my @vertices = (); + push(@vertices, $bb_min); + push(@vertices, Slic3r::Pointf3->new($bb_max->x(), $bb_min->y(), $bb_min->z())); + push(@vertices, Slic3r::Pointf3->new($bb_max->x(), $bb_max->y(), $bb_min->z())); + push(@vertices, Slic3r::Pointf3->new($bb_min->x(), $bb_max->y(), $bb_min->z())); + push(@vertices, Slic3r::Pointf3->new($bb_min->x(), $bb_min->y(), $bb_max->z())); + push(@vertices, Slic3r::Pointf3->new($bb_max->x(), $bb_min->y(), $bb_max->z())); + push(@vertices, $bb_max); + push(@vertices, Slic3r::Pointf3->new($bb_min->x(), $bb_max->y(), $bb_max->z())); + + my $max_x = 0.0; + my $max_y = 0.0; + + # margin factor to give some empty space around the bbox + my $margin_factor = 1.25; + + foreach my $v (@vertices) { + # project vertex on the plane perpendicular to camera forward axis + my $pos = Slic3r::Pointf3->new($v->x() - $bb_center->x(), $v->y() - $bb_center->y(), $v->z() - $bb_center->z()); + my $proj_on_normal = $pos->x() * $forward->x() + $pos->y() * $forward->y() + $pos->z() * $forward->z(); + my $proj_on_plane = Slic3r::Pointf3->new($pos->x() - $proj_on_normal * $forward->x(), $pos->y() - $proj_on_normal * $forward->y(), $pos->z() - $proj_on_normal * $forward->z()); + + # calculates vertex coordinate along camera xy axes + my $x_on_plane = $proj_on_plane->x() * $right->x() + $proj_on_plane->y() * $right->y() + $proj_on_plane->z() * $right->z(); + my $y_on_plane = $proj_on_plane->x() * $up->x() + $proj_on_plane->y() * $up->y() + $proj_on_plane->z() * $up->z(); + + $max_x = max($max_x, $margin_factor * 2 * abs($x_on_plane)); + $max_y = max($max_y, $margin_factor * 2 * abs($y_on_plane)); + } + + my ($cw, $ch) = $self->GetSizeWH; + my $min_ratio = min($cw / $max_x, $ch / $max_y); + + return $min_ratio; } sub zoom_to_bounding_box { @@ -697,6 +775,8 @@ sub zoom_to_bounding_box { # center view around bounding box center $self->_camera_target($bb->center); $self->on_viewport_changed->() if $self->on_viewport_changed; + $self->Resize($self->GetSizeWH) if $self->IsShownOnScreen; + $self->Refresh; } } @@ -1031,8 +1111,8 @@ sub Resize { #FIXME setting the size of the box 10x larger than necessary # is only a workaround for an incorrectly set camera. # This workaround harms Z-buffer accuracy! -# my $depth = 1.05 * $self->max_bounding_box->radius(); - my $depth = 10.0 * $self->max_bounding_box->radius(); +# my $depth = 1.05 * $self->max_bounding_box->radius(); + my $depth = max(@{ $self->max_bounding_box->size }); glOrtho( -$x/2, $x/2, -$y/2, $y/2, -$depth, $depth, @@ -1162,7 +1242,7 @@ sub Render { glMatrixMode(GL_MODELVIEW); glLoadIdentity(); - { + if (!TURNTABLE_MODE) { # Shift the perspective camera. my $camera_pos = Slic3r::Pointf3->new(0,0,-$self->_camera_distance); glTranslatef(@$camera_pos); diff --git a/lib/Slic3r/GUI/Plater.pm b/lib/Slic3r/GUI/Plater.pm index d59865491..5a29ab394 100644 --- a/lib/Slic3r/GUI/Plater.pm +++ b/lib/Slic3r/GUI/Plater.pm @@ -1856,6 +1856,7 @@ sub object_cut_dialog { $self->remove($obj_idx); $self->load_model_objects(grep defined($_), @new_objects); $self->arrange; + $self->{canvas3D}->zoom_to_volumes if $self->{canvas3D}; } } diff --git a/lib/Slic3r/GUI/Plater/3DPreview.pm b/lib/Slic3r/GUI/Plater/3DPreview.pm index 537cb0c8f..bd49bedb6 100644 --- a/lib/Slic3r/GUI/Plater/3DPreview.pm +++ b/lib/Slic3r/GUI/Plater/3DPreview.pm @@ -10,7 +10,7 @@ use base qw(Wx::Panel Class::Accessor); use Wx::Locale gettext => 'L'; -__PACKAGE__->mk_accessors(qw(print gcode_preview_data enabled _loaded canvas slider_low slider_high single_layer auto_zoom)); +__PACKAGE__->mk_accessors(qw(print gcode_preview_data enabled _loaded canvas slider_low slider_high single_layer)); sub new { my $class = shift; @@ -21,7 +21,6 @@ sub new { $self->{number_extruders} = 1; # Show by feature type by default. $self->{preferred_color_mode} = 'feature'; - $self->auto_zoom(1); # init GUI elements my $canvas = Slic3r::GUI::3DScene->new($self); @@ -207,41 +206,29 @@ sub new { my $selection = $choice_view_type->GetCurrentSelection(); $self->{preferred_color_mode} = ($selection == 4) ? 'tool' : 'feature'; $self->gcode_preview_data->set_type($selection); - $self->auto_zoom(0); $self->reload_print; - $self->auto_zoom(1); }); EVT_CHECKLISTBOX($self, $combochecklist_features, sub { my $flags = Slic3r::GUI::combochecklist_get_flags($combochecklist_features); $self->gcode_preview_data->set_extrusion_flags($flags); - $self->auto_zoom(0); $self->refresh_print; - $self->auto_zoom(1); }); EVT_CHECKBOX($self, $checkbox_travel, sub { $self->gcode_preview_data->set_travel_visible($checkbox_travel->IsChecked()); - $self->auto_zoom(0); $self->refresh_print; - $self->auto_zoom(1); }); EVT_CHECKBOX($self, $checkbox_retractions, sub { $self->gcode_preview_data->set_retractions_visible($checkbox_retractions->IsChecked()); - $self->auto_zoom(0); $self->refresh_print; - $self->auto_zoom(1); }); EVT_CHECKBOX($self, $checkbox_unretractions, sub { $self->gcode_preview_data->set_unretractions_visible($checkbox_unretractions->IsChecked()); - $self->auto_zoom(0); $self->refresh_print; - $self->auto_zoom(1); }); EVT_CHECKBOX($self, $checkbox_shells, sub { $self->gcode_preview_data->set_shells_visible($checkbox_shells->IsChecked()); - $self->auto_zoom(0); $self->refresh_print; - $self->auto_zoom(1); }); $self->SetSizer($main_sizer); @@ -374,7 +361,7 @@ sub load_print { } $self->show_hide_ui_elements('simple'); } else { - $self->{force_sliders_full_range} = (scalar(@{$self->canvas->volumes}) == 0) && $self->auto_zoom; + $self->{force_sliders_full_range} = (scalar(@{$self->canvas->volumes}) == 0); $self->canvas->load_gcode_preview($self->print, $self->gcode_preview_data, \@colors); $self->show_hide_ui_elements('full'); @@ -384,10 +371,6 @@ sub load_print { } $self->update_sliders($n_layers); - - if ($self->auto_zoom) { - $self->canvas->zoom_to_volumes; - } $self->_loaded(1); } }