pgrondek/polybar-dwm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(font): Check FcNameParse return value

Browse Source 
If FcNameParse returns NULL FcDefaultSubstitute segfaults

We log and throw an error here because the signal emitter swallows all
exceptions so if that exception was thrown, the bar would stop rendering
without any indication as to why.

Fixes #1435
This commit is contained in:
patrick96 2018-10-02 17:53:34 +02:00 committed by NBonaparte
parent 3c504bb913
commit 01f4957485
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/cairo/font.hpp
View File

@ -257,6 +257,12 @@ namespace cairo {
}); });
auto pattern = FcNameParse((FcChar8*)fontname.c_str()); auto pattern = FcNameParse((FcChar8*)fontname.c_str());
if(!pattern) {
logger::make().err("Could not parse font \"%s\"", fontname);
throw application_error("Could not parse font \"" + fontname + "\"");
}
FcDefaultSubstitute(pattern); FcDefaultSubstitute(pattern);
FcConfigSubstitute(nullptr, pattern, FcMatchPattern); FcConfigSubstitute(nullptr, pattern, FcMatchPattern);