From 037f6e6c4522e4504ab56e8f393a1c2f1b15f874 Mon Sep 17 00:00:00 2001 From: Patrick Ziegler Date: Sat, 5 Dec 2020 23:28:48 +0100 Subject: [PATCH] fix(xworkspaces): Never swallow updates (#2275) If two WM events arrive withing 25ms of one-another, the second one does not trigger a bar update. The module state is still correct, it is just not reflected in the bar. This somehow caused updates being swallowed in fluxbox, but only after PR #882 was merged, even though that 25ms restriction existed long before that. Fixes #2272 --- include/modules/xworkspaces.hpp | 2 -- src/modules/xworkspaces.cpp | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/modules/xworkspaces.hpp b/include/modules/xworkspaces.hpp index 62aafd90..d58cf455 100644 --- a/include/modules/xworkspaces.hpp +++ b/include/modules/xworkspaces.hpp @@ -110,8 +110,6 @@ namespace modules { // The following mutex is here to protect the data of this modules. // This can't be achieved using m_buildlock since we "CRTP override" get_output(). mutable mutex m_workspace_mutex; - - event_timer m_timer{0L, 25L}; }; } // namespace modules diff --git a/src/modules/xworkspaces.cpp b/src/modules/xworkspaces.cpp index 128524fd..f8b7b9b1 100644 --- a/src/modules/xworkspaces.cpp +++ b/src/modules/xworkspaces.cpp @@ -126,9 +126,7 @@ namespace modules { return; } - if (m_timer.allow(evt->time)) { - broadcast(); - } + broadcast(); } /**