From 25ef0299cb2bb835782d846a05695bcffc98b407 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20BOULMIER?= Date: Wed, 6 Mar 2019 03:00:11 -0500 Subject: [PATCH] fix(tray_client): remove copy ctor & assignment operator (#1675) tray_client class contains a reference so copy assignment operator is implicitly deleted. the dtor unembed the window so copying the class could lead to bug so the copy ctor is also deleted. Fixes #1674 --- include/x11/tray_client.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/x11/tray_client.hpp b/include/x11/tray_client.hpp index aae9b3f7..d74c9546 100644 --- a/include/x11/tray_client.hpp +++ b/include/x11/tray_client.hpp @@ -14,8 +14,8 @@ struct xembed_data; class tray_client { public: explicit tray_client(connection& conn, xcb_window_t win, unsigned int w, unsigned int h); - tray_client(const tray_client& c) = default; - tray_client& operator=(tray_client& c) = default; + tray_client(const tray_client& c) = delete; + tray_client& operator=(tray_client& c) = delete; ~tray_client();