pgrondek/polybar-dwm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(render): support stacked bars

Browse source 
We now take the bar position that the window manager gives us instead of trying
to calculate it ourselves. This is more correct when multiple bars are attached
to the same edge, as the window manager may move some of them in that
case (assuming override redirect is not enabled)
This commit is contained in:
Benno Fünfstück 2017-08-31 18:26:38 +02:00 • committed by Patrick Ziegler
parent eb742e228b
commit 51d58e7518
7 changed files with 48 additions and 19 deletions
src/components
bar.cpp

15
src/components/bar.cpp
View file

@ -761,9 +761,6 @@ void bar::handle(const evt::expose& evt) {
* state of the tray container even though the tray
* window restacking failed. Used as a fallback for
* tedious WM's, like i3.
*
* - Track the root pixmap atom to update the
* pseudo-transparent background when it changes
*/
void bar::handle(const evt::property_notify& evt) {
#ifdef DEBUG_LOGGER_VERBOSE
@ -776,6 +773,13 @@ void bar::handle(const evt::property_notify& evt) {
}
}
void bar::handle(const evt::configure_notify&) {
// The absolute position of the window in the root may be different after configuration is done
// (for example, because the parent is not positioned at 0/0 in the root window).
// Notify components that the geometry may have changed (used by the background manager for example).
m_sig.emit(signals::ui::update_geometry{});
}
bool bar::on(const signals::eventqueue::start&) {
m_log.trace("bar: Create renderer");
m_renderer = renderer::make(m_opts);
@ -789,6 +793,7 @@ bool bar::on(const signals::eventqueue::start&) {
if (!m_opts.cursor_click.empty() || !m_opts.cursor_scroll.empty() ) {
m_connection.ensure_event_mask(m_opts.window, XCB_EVENT_MASK_POINTER_MOTION);
}
m_connection.ensure_event_mask(m_opts.window, XCB_EVENT_MASK_STRUCTURE_NOTIFY);
m_log.info("Bar window: %s", m_connection.id(m_opts.window));
restack_window();
@ -800,6 +805,10 @@ bool bar::on(const signals::eventqueue::start&) {
m_log.trace("bar: Map window");
m_connection.map_window_checked(m_opts.window);
// With the mapping, the absolute position of our window may have changed (due to re-parenting for example).
// Notify all components that depend on the absolute bar position (such as the background manager).
m_sig.emit(signals::ui::update_geometry{});
// Reconfigure window position after mapping (required by Openbox)
// Required by Openbox
reconfigure_pos();