pgrondek/polybar-dwm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(string_util): Faster replace_all

Browse Source
This commit is contained in:
Michael Carlberg 2016-12-23 04:40:35 +01:00
parent fa0d77f267
commit b765094a29
1 changed files with 13 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/utils/string.cpp
View File

@ -1,3 +1,4 @@
#include <cstring>
#include <sstream> #include <sstream>
#include <utility> #include <utility>
@ -45,13 +46,13 @@ namespace string_util {
/** /**
* Replace first occurence of needle in haystack * Replace first occurence of needle in haystack
*/ */
string replace(const string& haystack, const string& needle, const string& reply, size_t start, size_t end) { string replace(const string& haystack, const string& needle, const string& replacement, size_t start, size_t end) {
string str(haystack); string str(haystack);
string::size_type pos; string::size_type pos;
if (needle != reply && (pos = str.find(needle, start)) != string::npos) { if (needle != replacement && (pos = str.find(needle, start)) != string::npos) {
if (end == string::npos || pos < end) { if (end == string::npos || pos < end) {
str = str.replace(pos, needle.length(), reply); str = str.replace(pos, needle.length(), replacement);
} }
} }
@ -61,27 +62,16 @@ namespace string_util {
/** /**
* Replace all occurences of needle in haystack * Replace all occurences of needle in haystack
*/ */
string replace_all(const string& haystack, const string& needle, const string& reply, size_t start, size_t end) { string replace_all(
string replaced; const string& haystack, const string& needle, const string& replacement, size_t start, size_t end) {
string result{haystack};
if (end == string::npos) { string::size_type pos;
end = haystack.length(); while ((pos = result.find(needle, start)) != string::npos && pos < result.length() &&
(end == string::npos || pos + needle.length() <= end)) {
result.replace(pos, needle.length(), replacement);
start = pos + replacement.length();
} }
return result;
for (size_t i = 0; i < haystack.length(); i++) {
if (i < start) {
replaced += haystack[i];
} else if (i + needle.length() > end) {
replaced += haystack[i];
} else if (haystack.compare(i, needle.length(), needle) == 0) {
replaced += reply;
i += needle.length() - 1;
} else {
replaced += haystack[i];
}
}
return replaced;
} }
/** /**