From f3ce047c5279c5ef6ca5a29fb2b61a8c152b4e59 Mon Sep 17 00:00:00 2001
From: patrick96 <p.ziegler96@gmail.com>
Date: Sat, 25 Mar 2023 19:28:43 +0100
Subject: [PATCH] tray: Remove delayed notifications

Unclear why it is needed, neither i3bar, nor stalonetray do delayed
notifications
---
 include/x11/tray_manager.hpp |  5 -----
 src/x11/tray_manager.cpp     | 25 -------------------------
 2 files changed, 30 deletions(-)

diff --git a/include/x11/tray_manager.hpp b/include/x11/tray_manager.hpp
index 03413380..578d2bd2 100644
--- a/include/x11/tray_manager.hpp
+++ b/include/x11/tray_manager.hpp
@@ -95,7 +95,6 @@ class manager : public xpp::event::sink<evt::expose, evt::client_message, evt::c
 
   bool acquire_selection(xcb_window_t& other_owner);
   void notify_clients();
-  void notify_clients_delayed();
 
   void track_selection_owner(xcb_window_t owner);
   void process_docking_request(xcb_window_t win);
@@ -196,10 +195,6 @@ class manager : public xpp::event::sink<evt::expose, evt::client_message, evt::c
    * Whether the tray is visible
    */
   bool m_hidden{false};
-
-  thread m_delaythread;
-
-  bool m_firstactivation{true};
 };
 
 } // namespace tray
diff --git a/src/x11/tray_manager.cpp b/src/x11/tray_manager.cpp
index d608938d..350eb16a 100644
--- a/src/x11/tray_manager.cpp
+++ b/src/x11/tray_manager.cpp
@@ -45,9 +45,6 @@ manager::manager(
 }
 
 manager::~manager() {
-  if (m_delaythread.joinable()) {
-    m_delaythread.join();
-  }
   m_connection.detach_sink(this, SINK_PRIORITY_TRAY);
   deactivate();
 }
@@ -141,15 +138,6 @@ void manager::activate() {
   m_state = state::ACTIVE;
 
   notify_clients();
-  // Send delayed notification
-  // TODO try to remove this?
-  // if (!m_firstactivation) {
-  //   notify_clients();
-  // } else {
-  //   notify_clients_delayed();
-  // }
-
-  m_firstactivation = false;
 }
 
 /**
@@ -390,19 +378,6 @@ void manager::notify_clients() {
   }
 }
 
-/**
- * Send delayed notification to pending clients
- */
-void manager::notify_clients_delayed() {
-  if (m_delaythread.joinable()) {
-    m_delaythread.join();
-  }
-  m_delaythread = thread([this]() {
-    this_thread::sleep_for(1s);
-    notify_clients();
-  });
-}
-
 /**
  * Track changes to the given selection owner
  * If it gets destroyed or goes away we can reactivate the tray_manager