polybar-dwm/include
Tim Schumacher 281fdf6382
The xworkspaces module should wait for EWMH to become available (#2429)
* The xworkspaces module should wait for EWMH to become available

Before this change if EWMH wasn't available the xworkspaces module was
permanently disabled. When polybar was started alongside the window
manager e.g. from .xinitrc this caused a race condition between polybar
and the window manager and the xworkspaces module may or may not be
displayed. After this change polybar will wait for EWMH to become
available. This change closes #1915, see that issue for more details.

Curiously this only required the removal of the error condition which
used the be raised when EWMH wasn't available. The xworkspaces module
will show up on the bar as soon as the first EWMH event is processed by
the existing event handling code. I can't argue much about the
correctness of this patch but it seems to work flawlessly in my testing
with xmonad. I didn't test any other window managers. Note that removing
the error condition below which checks that _NET_DESKTOP_VIEWPORT is
available might make this work with pin-workspaces=true. I couldn't test
the effects of that change because I only tested with xmonad and xmonad
doesn't support _NET_DESKTOP_VIEWPORT, so I didn't make that change.

* xworkspaces: Remove check fo _NET_DESKTOP_VIEWPORT

Implementations that don't support it will just return an empty list for
get_desktop_viewports and pin-workspaces won't do anything.

* Update changelog

Fixes #1915

Co-authored-by: Tim Schumacher <tim@timakro.de>
Co-authored-by: patrick96 <p.ziegler96@gmail.com>
2021-10-11 14:40:14 +02:00
..
adapters script: Fix concurrency issues (#2518) 2021-10-03 01:27:11 +02:00
cairo Fixed issues with border corner radii 2021-03-29 20:17:48 +02:00
components Allow running polybar without BAR argument (#2526) 2021-10-07 14:48:47 +02:00
drawtypes feat(xkeyboard): Icon matching using variant (#2521) 2021-10-05 12:12:47 +02:00
events Integrate bar taskqueue into eventloop (#2510) 2021-09-27 17:35:45 +02:00
modules The xworkspaces module should wait for EWMH to become available (#2429) 2021-10-11 14:40:14 +02:00
tags fix typos (#2524) 2021-10-04 23:46:38 +02:00
utils Create default config (#2511) 2021-10-05 13:07:19 +02:00
x11 Remove unused spin_lock 2021-09-21 21:43:27 +02:00
CMakeLists.txt refactor(cmake): Allow targets to be enabled individually 2020-12-24 02:20:38 +01:00
common.hpp refactor(build): Remove version number namespace 2019-05-17 16:49:47 +02:00
debug.hpp refactor: Cleanup 2017-01-11 03:07:28 +01:00
errors.hpp Add missing <stdexcept> header 2019-12-25 01:00:29 +01:00
settings.hpp.cmake Integrate bar taskqueue into eventloop (#2510) 2021-09-27 17:35:45 +02:00