52f0623315
A workspace is occupied if it is not active and there is at least one window managed by the WM (`_NET_CLIENT_LIST`) that has set `_NET_WM_DESKTOP` to that workspace. The behavior when `_NET_WM_DESKTOP` is not set is not yet clear but this is unlikely to happen since most WMs will position windows on some desktop. Closes #874 Fixes #1444 Fixes #1033 * Set Desktop OCCUPIED if a window moves there This covers more of an edge-case. I did this first by accident, it might vanish later on. * Replace tracking change of WS with currently used WS * Untrack occupied workspaces * Track windows and their desktops in pairs * Match type of occupied_desktops with current_desktop Because the index needs to be matched later on, type mismatches would be non-ideal. * Recreate the occupied desktops everytime and remove duplicates * Readd support for moving windows to other desktops * Use less characters to empty the vector * Rename variable storing the desktops * Recount windows on every occasion This alone simplifies the management and the lookup for occupation of a workspace * Keep track of number of windows in every workspace * Add debugging output that shall be removed before merging * Remove obsolete TODO * m_client_list should always be diff'd, since the desktop may change Therefore we update the desktop-count tally every time the client_list changes. It may just be a desktop-change without a change of clients.size()... * Add more logging-spam to understand window/desktop lifecycle * Lock event-handler to serialize handling of events * Fix occupied workspace counting and change to bool array Also, performance improvements when diffing new and old client lists * Fix crash when all clients are removed * Conform to linter and styleguide * Shorten conditional as it is standard enough Since this only guards against 0-divisions, it can be shortened without risking too much confusion down the road. * Guard against multiple threads accessing and modifying data Fixes #1444 Modification of internal data happens through the handle-method, while the build-method tries to access the data structures for display. Since some modifications clear e.g. the m_viewports, references may become invalid between looping over them an accessing them. The mutex should guard against this simultanuous access. * Do not 'adopt_lock', because calls come from very different threads To my understanding, adopt_lock has some dependency on the mutex-ownership. Since the lock is once called from the inside (in handle) and once from the outside (in build), there might be a problem. After brief testing, the segfaults happened fewer times. See #1444 * Also listen to _NET_WM_DESKTOP In order to move a window from one desktop to another, it is sufficient to set the desktop-property of that window. xmonad fires a lot of events in the case of moving a window, herbstluftwm only updates the _NET_WM_DESKTOP-atom of the window. This change reloads the clientlist in order to correctly set the desktop state "occupied". * Describe need and use of mutex It might be possible to relieve the guard in xworkspaces_module::handle, but I am unsure about this. Since xmonad emits a lot of events on almost every minor change, I would let the guard keep its post, avoiding race-conditions in event-handling. * Give temporary variables better names * Clarify purpose of loop About 80% of this comment are taken from https://github.com/jaagr/polybar/pull/882#discussion_r255317363 * Remove merge-remainder * Use a simpler method to list occupied desktops. Co-authored-by: Jérôme Boulmier <jerome.boulmier@outlook.fr> * Document m_clients field |
||
---|---|---|
.github/ISSUE_TEMPLATE | ||
cmake | ||
common | ||
contrib | ||
doc | ||
include | ||
lib | ||
src | ||
tests | ||
.clang-format | ||
.clang-tidy | ||
.codecov.yml | ||
.editorconfig | ||
.gitignore | ||
.gitmodules | ||
.travis.yml | ||
.valgrind-suppressions | ||
.ycm_extra_conf.py | ||
banner.png | ||
build.sh | ||
CMakeLists.txt | ||
config.cmake | ||
LICENSE | ||
README.md | ||
SUPPORT.md | ||
version.txt |
A fast and easy-to-use tool for creating status bars.
Polybar aims to help users build beautiful and highly customizable status bars for their desktop environment, without the need of having a black belt in shell scripting. Here are a few screenshots showing you what it can look like:
You can find polybar configs for these example images (and other configs) here.
If you need help, check out the Support page.
Please report any bugs you find by creating an issue ticket here on GitHub. Make sure you include steps on how to reproduce it.
Table of Contents
Introduction
The main purpose of Polybar is to help users create awesome status bars. It has built-in functionality to display information about the most commonly used services. Some of the services included so far:
- Systray icons
- Window title
- Playback controls and status display for MPD using libmpdclient
- ALSA volume controls
- Workspace and desktop panel for bspwm and i3
- Workspace module for EWMH compliant window managers
- Keyboard layout and indicator status
- CPU and memory load indicator
- Battery display
- Network connection details
- Backlight level
- Date and time label
- Time-based shell script execution
- Command output tailing
- User-defined menu tree
- Inter-process messaging
- And more...
See the wiki for more details.
Getting Help
If you find yourself stuck, have a look at our Support page for resources where you can find help.
Getting started
Polybar was already packaged for the distros listed below. If you can't find your distro here, you will have to build from source.
If you create a package for any other distribution, please consider contributing the template.
If you are using Arch Linux, you can install the AUR package polybar-git to get the latest version, or polybar for the latest stable release.
If you are using Void Linux, you can install polybar using xbps-install -S polybar
.
If you are using NixOS, polybar is available in both the stable and unstable channels and can be installed with the command nix-env -iA nixos.polybar
.
If you are using Slackware, polybar is available from the SlackBuilds repository.
If you are using Source Mage GNU/Linux, polybar spell is available in test grimoire and can be installed via cast polybar
.
If you are using openSUSE, polybar is available from OBS repository. Package is available for openSUSE Leap 15 and Tumbleweed.
If you are using FreeBSD, polybar can be installed using pkg install polybar
. Make sure you are using the latest
package branch.
If you are using Gentoo, both release and git-master versions are available in the main repository.
Dependencies
A compiler with C++14 support (clang-3.4+, gcc-5.1+), cmake 3.1+, git
cairo
libxcb
python2
xcb-proto
xcb-util-image
xcb-util-wm
Optional dependencies:
xcb-util-cursor
required for thecursor-click
andcursor-scroll
settingsxcb-util-xrm
required for accessing X resources with${xrdb:...}
Optional dependencies for extended module support:
xcb-xkb
required byinternal/xkeyboard
alsa-lib
required byinternal/alsa
libpulse
required byinternal/pulseaudio
i3-wm
required byinternal/i3
jsoncpp
required byinternal/i3
libmpdclient
required byinternal/mpd
libcurl
required byinternal/github
libnl-genl
orwireless_tools
required byinternal/network
Find a more complete list on the dedicated wiki page.
Building from source
Please report any problems you run into when building the project.
Download the polybar-<version>.tar
for the version you want to build from the
release page, extract it with
tar xvf polybar-<version>.tar
and go into the extracted folder. There, run
the following commands:
$ mkdir build
$ cd build
$ cmake ..
$ make -j$(nproc)
$ sudo make install
There's also a helper script available in the root folder:
$ ./build.sh
For more info, have a look at the Compiling wiki page.
Configuration
Details on how to setup and configure the bar and each module have been moved to the wiki.
Install the example configuration
Run the following inside the build directory:
$ make userconfig
Or you can copy the example config from /usr/share/doc/polybar/config
or /usr/local/share/doc/polybar/config
(depending on your install parameters)
Launch the example bar
$ polybar example
Running
See the wiki for details on how to run polybar.
Community
Want to get in touch?
- We have our own subreddit at r/polybar.
- Chat with us in the
#polybar
IRC channel on thechat.freenode.net
server.
Contributors
Owner
- Michael Carlberg @jaagr
Maintainers
- @NBonaparte
- Chase Geigle @skystrife
- Patrick Ziegler @patrick96
Logo Design by
All Contributors
License
Polybar is licensed under the MIT license. See LICENSE for more information.