pgrondek/polybar-dwm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
151a263654
polybar-dwm/CHANGELOG.md
Vincent Bernat 151a263654
fix(monitor): do not include outputs when monitors are supported (#2485) 
* fix(monitor): do not include outputs when monitors are supported

Previously, when splitting an output into two monitors, `polybar -m`
would report both the splitted monitors and the output. This was not
caught by the the clone detection as the detection works by removing
monitors contained into another monitors (and monitors were excluded
from that logic) and we want the other way around: outputs covered by
monitors should be ignored.

Instead of trying to detect covered outputs, the solution is quite
simple: when monitors are supported, do not consider outputs, unless
we request all outputs. A monitor can be set primary (and RandR
reports primary outputs as primary monitors). The only information we
would miss from monitors are things like refresh rate and EDID. We
don't need that, so we are fine.

As monitors are only created for connected output (and they are in
this case "active") or disconnected output if they are mapped (and
they are in this case "inactive"), I am a bit unsure if we have
exactly the same behaviour as previously when `connected_only` is set
to `false`.

As some modules require an output, we keep the output in the
`monitor_t` structure and we ensure it is correctly set when using
monitors. A monitor can have 0 or several outputs. We only handle the
0 and 1 cases. When a monitor has more outputs, only the first one is
used. AFAIK, only the xbacklight module needs that and I think we are
fine waiting for a user needing this module and merging monitors.

The C++ binding fail to expose the `outputs()` method to iterate over
the outputs of a monitor. This seems to be a bug in XPP. The field is
correctly defined in the RandR XML file and it works with the Python
binding.

```xml
	<struct name="MonitorInfo">
		<field type="ATOM" name="name" />
		<field type="BOOL" name="primary" />
		<field type="BOOL" name="automatic" />
		<field type="CARD16" name="nOutput" />
		<field type="INT16" name="x" />
		<field type="INT16" name="y" />
		<field type="CARD16" name="width" /> <!-- pixels -->
		<field type="CARD16" name="height" /> <!-- pixels -->
		<field type="CARD32" name="width_in_millimeters" />
		<field type="CARD32" name="height_in_millimeters" />
		<list type="OUTPUT" name="outputs">
		    <fieldref>nOutput</fieldref>
		</list>
	</struct>
```

Falling back to C only to access the list of outputs is not enough
because the list is appended to the structure and not visible through
the public API. When copied, the structure loses the list of monitors.

Also, change the mention "XRandR monitor" to "no output" when there is
no output attached. People using monitors know what it means and it is
useful to catch a future regression where we don't have an output at
all (which would break the brightness plugin).

Fix #2481

* Update CHANGELOG.md

Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com>
2021-09-02 18:07:21 +02:00

8.4 KiB
Raw Blame History

Changelog

All notable changes to this project will be documented in this file. Each release should have the following subsections, if entries exist, in the given order: Breaking, Build, Deprecated, Removed, Added, Changed, Fixed, Security.

The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.

Unreleased

Breaking

  • We added the backslash escape character (\) for configuration values. This means that the literal backslash character now has special meaning in configuration files, therefore if you want to use it in a value as a literal backslash, you need to escape it with the backslash escape character. The parser logs an error if any unescaped backslashes are found in a value. This affects you only if you are using two consecutive backslashes in a value, which will now be interpreted as a single literal backslash. #2354
  • We rewrote our tag parser. This shouldn't break anything, if you experience any problems, please let us know. The new parser now gives errors for certain invalid tags where the old parser would just silently ignore them. Adding extra text to the end of a valid tag now produces an error. For example, tags like %{T-a}, %{T2abc}, %{rfoo}, and others will now start producing errors. This does not affect you unless you are producing your own formatting tags (for example in a script) and you are using one of these invalid tags.

Build

  • Bump the minimum cmake version to 3.5
  • The BUILD_IPC_MSG option has been renamed to BUILD_POLYBAR_MSG
  • Building the documentation is now enabled by default and not just when sphinx-build is found.
  • Users can control exactly which targets should be available with the following cmake options (together with their default value):
    • BUILD_POLYBAR=ON - Builds the polybar executable
    • BUILD_POLYBAR_MSG=ON - Builds the polybar-msg executable
    • BUILD_TESTS=OFF - Builds the test suite
    • BUILD_DOC=ON - Builds the documentation
    • BUILD_DOC_HTML=BUILD_DOC - Builds the html documentation (depends on BUILD_DOC)
    • BUILD_DOC_MAN=BUILD_DOC - Builds the manpages (depends on BUILD_DOC)
    • BUILD_CONFIG=ON - Generates sample config
    • BUILD_SHELL=ON - Generates shell completion files
    • DISABLE_ALL=OFF - Disables all above targets by default. Individual targets can still be enabled explicitly.
  • The documentation can no longer be built by directly configuring the doc directory.
  • The sample config file is now placed in the generated-sources folder inside whatever folder you invoked cmake from instead of in the root folder of the repository.
  • The POLYBAR_FLAGS cmake variable can be used to pass extra C++ compiler flags.

Added

  • Option to always show urgent windows in i3 module when pin-workspace is active (2374)
  • internal/xworkspaces: reverse-scroll can be used to reverse the scroll direction when cycling through desktops.
  • The backslash escape character (\). #2354
  • Warn states for the cpu, memory, fs, and battery modules. (#570, #956, #1871, #2141)
    • internal/battery: format-low, label-low, animation-low, low-at = 10.
    • internal/cpu: format-warn, label-warn, warn-percentage = 80
    • internal/fs: format-warn, label-warn, warn-percentage = 90
    • internal/memory: format-warn, label-warn, warn-percentage = 90
  • radius now affects the bar border as well (#1566)
  • Per-corner corner radius with radius-{bottom,top}-{left,right} (#2294)
  • internal/network: speed-unit = B/s can be used to customize how network speeds are displayed.
  • internal/xkeyboard: %variant% can be used to parse the layout variant (#316)
  • Added .ini extension check to the default config search. (#2323)
  • Config option to hide a certain module (hidden = false) (#2108)
  • Actions to control visibility of modules (module_toggle, module_show, and module_hide) (#2108)
  • internal/xworkspaces: Make the urgent hint persistent (#1081)
  • internal/network: interface-type may be used in place of interface to automatically select a network interface (#2025)
  • internal/xworkspaces: %nwin% can be used to display the number of open windows per workspace (#604)
  • internal/backlight: added use-actual-brightness option
  • Added wm-restack = generic option that lowers polybar to the bottom of the stack. Fixes the issue where the bar is being drawn on top of fullscreen windows in xmonad. (#2205)
  • Added occupied-scroll = true option to bspwm module. Allows scrolling only through occupied desktops only. (#2427)
  • custom/ipc: send action to send arbitrary strings to be displayed in the module. (#2455)

Changed

  • Slight changes to the value ranges the different ramp levels are responsible for in the cpu, memory, fs, and battery modules. The first and last level are only used for everything at or below and at and above the edges of the value range, respectively. The other levels are evenly distributed over the value range as before.
  • custom/script: interval now defaults to 0 if tail = true as per the documentation.
  • internal/network:
    • Increased precision for upload and download speeds: 0 decimal places for KB/s (as before), 1 for MB/s and 2 for GB/s.

Fixed

  • Trailing space after the layout label when indicators are empty and made sure right amount of spacing is added between the indicator labels, in the xkeyboard module. (#2292)
  • Parser error if click command contained } (#2040)
  • Slight imprecision when calculating percentages. This caused the volume reported by alsa to be off by one. (#2399)
  • internal/backlight: With amdgpu backlights, the brightness indicator was slightly behind. (#2367)
  • Warning message regarding T@ in bspwm module (#2371)
  • polybar -m used to show both physical outputs and randr monitors, even if the outputs were covered by monitors. (#2481)

3.5.6 - 2021-05-24

Build

  • Support building documentation on sphinx 4.0 (#2424)

Fixed

  • Tray icons sometimes appears outside of bar (#2430, #1679)
  • Crash in the i3 module (#2416)

3.5.5 - 2021-03-01

Build

  • Support older python sphinx versions again (#2356)

3.5.4 - 2021-01-07

Fixed

  • Wrong text displayed if module text ends with } (#2331)

3.5.3 - 2020-12-23

Build

  • Don't use git when building documentation (#2309)

Fixed

  • Empty color values are no longer treated as invalid and no longer produce an error.